From: Lina Iyer <ilina@codeaurora.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
georgi.djakov@linaro.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
dianders@chromium.org, swboyd@chromium.org,
rnayak@codeaurora.org, lsrao@codeaurora.org
Subject: Re: [PATCH] soc: qcom: rpmh: Update rpmh_invalidate function to return void
Date: Thu, 18 Jun 2020 08:10:21 -0600 [thread overview]
Message-ID: <20200618141021.GG12942@codeaurora.org> (raw)
In-Reply-To: <1592485553-29163-1-git-send-email-mkshah@codeaurora.org>
On Thu, Jun 18 2020 at 07:06 -0600, Maulik Shah wrote:
>Currently rpmh_invalidate() always returns success. Update its
>return type to void.
>
>Suggested-by: Stephen Boyd <swboyd@chromium.org>
>Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Lina Iyer <ilina@codeaurora.org>
>---
> drivers/interconnect/qcom/bcm-voter.c | 6 +-----
> drivers/soc/qcom/rpmh.c | 4 +---
> include/soc/qcom/rpmh.h | 7 ++++---
> 3 files changed, 6 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c
>index 2a11a63..a3d2ef1 100644
>--- a/drivers/interconnect/qcom/bcm-voter.c
>+++ b/drivers/interconnect/qcom/bcm-voter.c
>@@ -266,11 +266,7 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter)
> if (!commit_idx[0])
> goto out;
>
>- ret = rpmh_invalidate(voter->dev);
>- if (ret) {
>- pr_err("Error invalidating RPMH client (%d)\n", ret);
>- goto out;
>- }
>+ rpmh_invalidate(voter->dev);
>
> ret = rpmh_write_batch(voter->dev, RPMH_ACTIVE_ONLY_STATE,
> cmds, commit_idx);
>diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
>index f2b5b46c..b61e183 100644
>--- a/drivers/soc/qcom/rpmh.c
>+++ b/drivers/soc/qcom/rpmh.c
>@@ -497,7 +497,7 @@ int rpmh_flush(struct rpmh_ctrlr *ctrlr)
> *
> * Invalidate the sleep and wake values in batch_cache.
> */
>-int rpmh_invalidate(const struct device *dev)
>+void rpmh_invalidate(const struct device *dev)
> {
> struct rpmh_ctrlr *ctrlr = get_rpmh_ctrlr(dev);
> struct batch_cache_req *req, *tmp;
>@@ -509,7 +509,5 @@ int rpmh_invalidate(const struct device *dev)
> INIT_LIST_HEAD(&ctrlr->batch_cache);
> ctrlr->dirty = true;
> spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
>-
>- return 0;
> }
> EXPORT_SYMBOL(rpmh_invalidate);
>diff --git a/include/soc/qcom/rpmh.h b/include/soc/qcom/rpmh.h
>index f9ec353..bdbee1a 100644
>--- a/include/soc/qcom/rpmh.h
>+++ b/include/soc/qcom/rpmh.h
>@@ -20,7 +20,7 @@ int rpmh_write_async(const struct device *dev, enum rpmh_state state,
> int rpmh_write_batch(const struct device *dev, enum rpmh_state state,
> const struct tcs_cmd *cmd, u32 *n);
>
>-int rpmh_invalidate(const struct device *dev);
>+void rpmh_invalidate(const struct device *dev);
>
> #else
>
>@@ -38,8 +38,9 @@ static inline int rpmh_write_batch(const struct device *dev,
> const struct tcs_cmd *cmd, u32 *n)
> { return -ENODEV; }
>
>-static inline int rpmh_invalidate(const struct device *dev)
>-{ return -ENODEV; }
>+static inline void rpmh_invalidate(const struct device *dev)
>+{
>+}
>
> #endif /* CONFIG_QCOM_RPMH */
>
>--
>QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
>of Code Aurora Forum, hosted by The Linux Foundation
>
next prev parent reply other threads:[~2020-06-18 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 13:05 [PATCH] soc: qcom: rpmh: Update rpmh_invalidate function to return void Maulik Shah
2020-06-18 14:10 ` Lina Iyer [this message]
2020-06-19 8:20 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618141021.GG12942@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox