From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C447DC433DF for ; Thu, 18 Jun 2020 14:13:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADAF720739 for ; Thu, 18 Jun 2020 14:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730724AbgFRONv (ORCPT ); Thu, 18 Jun 2020 10:13:51 -0400 Received: from mga01.intel.com ([192.55.52.88]:41861 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730707AbgFRONu (ORCPT ); Thu, 18 Jun 2020 10:13:50 -0400 IronPort-SDR: c4aarDERm/AHYz4XmbDck8mtVoDgoCk88l9yoXlq1vfB8fFDue9+NvhsvKxdrtqTYWXxviZfWW p6WMW/v7adLw== X-IronPort-AV: E=McAfee;i="6000,8403,9655"; a="160677192" X-IronPort-AV: E=Sophos;i="5.73,526,1583222400"; d="scan'208";a="160677192" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2020 07:13:49 -0700 IronPort-SDR: jk6Z/xghMixVveuzV47x56u8F2cumT/HPXJZLEnYZ6tSN6mZMWxSmnDjo/hzQoCQxld7bbEMsj m7YAfMudqZ0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,526,1583222400"; d="scan'208";a="262035116" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga007.fm.intel.com with ESMTP; 18 Jun 2020 07:13:48 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id 7BDFA301674; Thu, 18 Jun 2020 07:13:49 -0700 (PDT) Date: Thu, 18 Jun 2020 07:13:49 -0700 From: Andi Kleen To: Gaurav Singh Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ravi Bangoria , "open list:PERFORMANCE EVENTS SUBSYSTEM" Subject: Re: [PATCH] [perf] sort : Fix null pointer dereference in _hist_entry__sym_snprintf Message-ID: <20200618141349.GA793265@tassilo.jf.intel.com> References: <20200618003040.26360-1-gaurav1086@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618003040.26360-1-gaurav1086@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index d42339df20f8..25c7c96893f6 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -294,6 +294,9 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms, > u64 ip, char level, char *bf, size_t size, > unsigned int width) > { > + if (!ms) > + return 0; > + > struct symbol *sym = ms->sym; > struct map *map = ms->map; > size_t ret = 0; This should have given warnings because Linux and perf coding style forbids fixed statement/declarations. Also what's the backtrace where it is NULL? Perhaps better to fix it in the caller. -Andi