Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

Uladzislau Rezki
2020-06-19T15:47:10Z

On Thu, Jun 18, 2020 at 02:34:27PM -0700, Paul E. McKenney wrote:
> On Thu, Jun 18, 2020 at 11:17:09PM +0200, Uladzislau Rezki wrote:
> > > > <snip>
> > > > trace_rcu_invoke_kfree_bulk_callback(
> > > > rcu_state.name, bkvhead[i]->nr_records,
> > > > bkvhead[i]->records);
> > > > if (i == 0)
> > > > kfree_bulk(bkvhead[i]->nr_records,
> > > > bkvhead[i]->records);
> > > > else
> > > > vfree_bulk(bkvhead[i]->nr_records,
> > > > bkvhead[i]->records);
> > > > <snip>
> > > >
> > > > Matthew, what is your thought?
> > >
> > > That was my thinking too. If we had a kvfree_bulk(), I would expect it to
> > > handle a mixture of vfree and kfree, but you've segregated them already.
> > > So I think this is better.
> > >
> > Yes, the segregation is done. Having vfree_bulk() is enough then.
> > We are on the same page :)
>
> Very good. When does kfree_rcu() and friends move out of kernel/rcu?
>
Do you mean to move the whole logic of kfree_rcu() from top to down to mm/?

Thanks!

--
Vlad Rezki