From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B75EC433E0 for ; Fri, 19 Jun 2020 08:52:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4799D214DB for ; Fri, 19 Jun 2020 08:52:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731660AbgFSIwE (ORCPT ); Fri, 19 Jun 2020 04:52:04 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:44077 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731587AbgFSIv4 (ORCPT ); Fri, 19 Jun 2020 04:51:56 -0400 Received: from mail.cetitecgmbh.com ([87.190.42.90]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MhFpq-1jI4vB3PPu-00ePJ9; Fri, 19 Jun 2020 10:51:39 +0200 Received: from pflvmailgateway.corp.cetitec.com (unknown [127.0.0.1]) by mail.cetitecgmbh.com (Postfix) with ESMTP id CEECC651899; Fri, 19 Jun 2020 08:51:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at cetitec.com Received: from mail.cetitecgmbh.com ([127.0.0.1]) by pflvmailgateway.corp.cetitec.com (pflvmailgateway.corp.cetitec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Afr88sTZPnb7; Fri, 19 Jun 2020 10:51:38 +0200 (CEST) Received: from pflmari.corp.cetitec.com (unknown [10.10.5.94]) by mail.cetitecgmbh.com (Postfix) with ESMTPSA id 9403864C8CE; Fri, 19 Jun 2020 10:51:38 +0200 (CEST) Received: by pflmari.corp.cetitec.com (Postfix, from userid 1000) id 6F168804FB; Fri, 19 Jun 2020 10:51:38 +0200 (CEST) Date: Fri, 19 Jun 2020 10:51:38 +0200 From: Alex Riesen To: Kieran Bingham Cc: Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v5 6/9] media: adv748x: prepare/enable mclk when the audio is used Message-ID: <20200619085138.GA7780@pflmari> Mail-Followup-To: Alex Riesen , Kieran Bingham , Geert Uytterhoeven , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Rob Herring , Mark Rutland , Kuninori Morimoto , devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <646b0f32-2f83-281a-ccc0-eb88f82eb7a3@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <646b0f32-2f83-281a-ccc0-eb88f82eb7a3@ideasonboard.com> X-Provags-ID: V03:K1:Z40wuChLtVuyGhpa0eSWHYpnckmvA0AneQ/xLB1dN7j3mlvkxGf 4UIeAZFH8vvMZW1KygniVP7aD1bBW0jwp5C70Q7OLQXiOfmQ6UpXmX2gaB66TEyJ187Rl/D JuoSANAV6qZcQFbUIDyyxFis/m4+hL7qZLuu2g19EShFHRh6tXMDh1vM20l9ZWrBONQtOdJ qc8AttDstYFLDDvDXvaLg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ph7/p+iTgdc=:abepqPEyNSYfo2jDEeHIAl MXYHgg7UaQeGzy9u0Z1N0+DGzHKfgsQFvkCrf9ZZzwF8icVrJSJl7LmJA+L45xkr675Bx0T0p Zv5rHv+6GeP2mvw9XcHTjYeWlxpVTU7C65ucFBi2j0XxreYfKsWOsI9tJc/REuIxdQ9BiuTMS 8rMdEH+Nwi4OSSUYAJHzJ6PhJDLn5jlRMR8wjO+dm0Fhebfu/1B9Ff0Qaig7E6FRW6quVVyq5 pgYuzd/5gCvDkSewvVcNHZYMBteeoa/quOLg043EQTiymbjxBCieUIrZ0AmcX14IOyUmKZ6RC EmIBroD4CTFTK6zmRhd/Ey81gghk1LFinHfVrGTGBYd/W+qDfnZ2PQznE05LQpL+Fy+e/e9Kk xHXF+hald28fylV241YN9NSsS/V3EyTGheYOOObd4zOflamgk0QeBxOod70rrXc7HoMvSf6/B nTeIVfDTWvbLnvO1TBL7IdIFueDzFc/n9P3uTZCaNMU5358YbhudnMK9wuBNWa1RvsZUPTwkE iZ3qKrTRQe/AcNs4q3X6/JOl33MyYlxtCO3LOM1UOsOxbRjSkPXZFpiaeXSjW9CE5+VsPzmmx IPpiz86zpWxuDm1K4qk2AcUT6bEmlaOqAXK5FmujDNWrbsm8MD+SoVNINJDliVrVDVgHpOxf+ QAPu6sLH0jf1imxYnlmO8vKm1loj6ZC0/YpnvsUlDZFckfU8wiqbaHhMBmGy6+ZBttpSYpJ9j fZfO08u0uUnjrgt82gUhM8eeyrRUTG9cfGbohbncNUfkNEfAK+5hshd7yvIRL8ulrIY/5rgwf /wXHTbZNKSvIriL0ExZP3TSmwQAjeRep3wVEP53hSe7zyucRDKDZV9b84Y+eKxZecyXToac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kieran Bingham, Thu, Jun 18, 2020 18:23:14 +0200: > On 02/04/2020 19:34, Alex Riesen wrote: > > --- a/drivers/media/i2c/adv748x/adv748x-dai.c > > +++ b/drivers/media/i2c/adv748x/adv748x-dai.c > > @@ -117,11 +117,22 @@ static int adv748x_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) > > > > static int adv748x_dai_startup(struct snd_pcm_substream *sub, struct snd_soc_dai *dai) > > { > > + int ret; > > struct adv748x_state *state = state_of(dai); > > > > if (sub->stream != SNDRV_PCM_STREAM_CAPTURE) > > return -EINVAL; > this looks quite bunched up so : > > Newline... Will do. > > - return set_audio_pads_state(state, 1); > > + ret = set_audio_pads_state(state, 1); > > + if (ret) > > + goto fail; > > With no action required to cleanup here, I would just > return ret; > and remove the fail: label. Of course. > > + ret = clk_prepare_enable(mclk_of(state)); > > + if (ret) > > + goto fail_pwdn; > > newline... > > > + return 0; > > newline... > > Other than that: > > Reviewed-by: Kieran Bingham Thanks!