Re: [PATCH 4.19 172/267] net: ethernet: fec: move GPR register offset and bit into DT

Greg Kroah-Hartman
2020-06-20T08:02:44Z

On Fri, Jun 19, 2020 at 11:04:32PM +0200, Pavel Machek wrote:
> Hi!
>
> > [ Upstream commit 8a448bf832af537d26aa557d183a16943dce4510 ]
> >
> > The commit da722186f654 (net: fec: set GPR bit on suspend by DT
> > configuration) set the GPR reigster offset and bit in driver for
> > wake on lan feature.
> >
> > But it introduces two issues here:
> > - one SOC has two instances, they have different bit
> > - different SOCs may have different offset and bit
> >
> > So to support wake-on-lan feature on other i.MX platforms, it should
> > configure the GPR reigster offset and bit from DT.
>
> Ok, so this really is not a bugfix.
>
> Plus, it really depends on dts changes...
>
> > --- a/drivers/net/ethernet/freescale/fec_main.c
> > {
> > struct device_node *gpr_np;
> > + u32 out_val[3];
> > int ret = 0;
> >
> > - if (!dev_info)
> > - return 0;
> > -
> > - gpr_np = of_parse_phandle(np, "gpr", 0);
> > + gpr_np = of_parse_phandle(np, "fsl,stop-mode", 0);
> > if (!gpr_np)
> > return 0;
> >
>
> ...and those changes are not present in v4.19. There's no
> fsl,stop-mode in v4.19, unlike mainline.
>
> pavel@amd:~/cip/krc$ grep -ri fsl,stop-mode arch/arm*/boot/dts
> pavel@amd:~/cip/krc$
>
> This will break driver for everyone, AFAICT. Please drop it from
> stable.

Thanks for the report, dropping it from everywhere.

greg k-h