Re: [RFC v9 09/11] vhost/scsi: switch to buf APIs

Stefan Hajnoczi
2020-06-22T10:02:01Z

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Fri, Jun 19, 2020 at 08:23:00PM +0200, Eugenio Pérez wrote:
> @@ -1139,9 +1154,9 @@ vhost_scsi_send_tmf_reject(struct vhost_scsi *vs,
> iov_iter_init(&iov_iter, READ, &vq->iov[vc->out], vc->in, sizeof(rsp));
>
> ret = copy_to_iter(&rsp, sizeof(rsp), &iov_iter);
> - if (likely(ret == sizeof(rsp)))
> - vhost_add_used_and_signal(&vs->dev, vq, vc->head, 0);
> - else
> + if (likely(ret == sizeof(rsp))) {
> + vhost_scsi_signal_noinput(&vs->dev, vq, &vc->buf);
> + } else
> pr_err("Faulted on virtio_scsi_ctrl_tmf_resp\n");
> }

The curly brackets are not necessary, but the patch still looks fine:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]