Re: [PATCH v2] Introduce MEN 16Z192-00 CAN controller driver

kernel test robot
2020-06-19T11:25:14Z

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

Hi Abhijeet,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.8-rc1 next-20200618]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Abhijeet-Badurkar/Introduce-MEN-16Z192-00-CAN-controller-driver/20200619-161212
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 5e857ce6eae7ca21b2055cca4885545e29228fe2
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/net/can/men_z192_can.c:704:6: warning: no previous prototype for 'men_z192_set_can_state' [-Wmissing-prototypes]
704 | void men_z192_set_can_state(struct net_device *ndev)
| ^~~~~~~~~~~~~~~~~~~~~~

vim +/men_z192_set_can_state +704 drivers/net/can/men_z192_can.c

703
> 704 void men_z192_set_can_state(struct net_device *ndev)
705 {
706 struct men_z192 *priv = netdev_priv(ndev);
707 struct men_z192_regs __iomem *regs = priv->regs;
708 enum can_state rx_state, tx_state;
709 u32 status;
710
711 status = readl(&regs->rx_tx_sts);
712
713 rx_state = bus_state_map[MEN_Z192_GET_RSTATE(status)];
714 tx_state = bus_state_map[MEN_Z192_GET_TSTATE(status)];
715
716 can_change_state(ndev, NULL, tx_state, rx_state);
717 }
718

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74074 bytes --]