From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90082C433DF for ; Sat, 20 Jun 2020 15:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AFB721532 for ; Sat, 20 Jun 2020 15:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbgFTPaS (ORCPT ); Sat, 20 Jun 2020 11:30:18 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:41224 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbgFTPaQ (ORCPT ); Sat, 20 Jun 2020 11:30:16 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7CF968053D; Sat, 20 Jun 2020 17:30:13 +0200 (CEST) Date: Sat, 20 Jun 2020 17:30:12 +0200 From: Sam Ravnborg To: Dmitry Osipenko Cc: Laurent Pinchart , Thierry Reding , Rob Herring , Frank Rowand , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Message-ID: <20200620153012.GA22743@ravnborg.org> References: <20200617222703.17080-1-digetx@gmail.com> <20200617222703.17080-8-digetx@gmail.com> <20200620112132.GB16901@ravnborg.org> <20200620114934.GB5829@pendragon.ideasonboard.com> <20200620143114.GA22329@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=I1XKC5YfttuoCrzH9m8A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote: > 20.06.2020 17:31, Sam Ravnborg пишет: > > Hi Dmitry > > > >> > >> Oops! Good catch! > > Yep, thanks Laurent. Should have taken a better look before applying. > > > >> Indeed, I blindly set the LVDS type to all these > >> panels. Please revert this patch, I'll double check each panel and > >> prepare an updated version of this patch. Thank you very much for the > >> review! > > > > If you can prepare a fix within a few days then lets wait for that. > > I will do a better review next time. > > Hello Sam, > > I should be able to make it later today or tomorrow. Could you please > clarify what do you mean by the fix, do you what it to be as an > additional patch on top of the applied one or a new version of the patch? An additional patch on top of the one applied. It shall carry a proper fixes: tag like this: Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels") Cc: Dmitry Osipenko Cc: Sam Ravnborg Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Sam