From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E847C433E1 for ; Sat, 20 Jun 2020 21:33:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A637246DF for ; Sat, 20 Jun 2020 21:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729044AbgFTVdI (ORCPT ); Sat, 20 Jun 2020 17:33:08 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:40848 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728942AbgFTVdI (ORCPT ); Sat, 20 Jun 2020 17:33:08 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 4C1A080462; Sat, 20 Jun 2020 23:33:03 +0200 (CEST) Date: Sat, 20 Jun 2020 23:33:02 +0200 From: Sam Ravnborg To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, Collabora Kernel ML , Chun-Kuang Hu , Jernej Skrabec , drinkcat@chromium.org, Jonas Karlman , David Airlie , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Neil Armstrong , Andrzej Hajda , linux-mediatek@lists.infradead.org, Laurent Pinchart , hsinyi@chromium.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge Message-ID: <20200620213302.GC74146@ravnborg.org> References: <20200615203108.786083-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615203108.786083-1-enric.balletbo@collabora.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=D19gQVrFAAAA:8 a=e5mUnYsNAAAA:8 a=BRaO1eXc-lkJNI1u5j0A:9 a=CjuIK1q_8ugA:10 a=W4TVW4IDbPiebHqcZpNg:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric On Mon, Jun 15, 2020 at 10:31:01PM +0200, Enric Balletbo i Serra wrote: > (This resend is to fix some trivial conflicts due the merge window) > > The PS8640 dsi-to-eDP bridge driver is using the panel bridge API, > however, not all the components in the chain have been ported to the > drm_bridge API. Actually, when a panel is attached the default panel's mode > is used, but in some cases we can't get display up if mode getting from > eDP control EDID is not chosen. > > This series address that problem, first implements the .get_edid() > callback in the PS8640 driver (which is not used until the conversion is > done) and then, converts the Mediatek DSI driver to use the drm_bridge > API. > > As far as I know, we're the only users of the mediatek dsi driver in > mainline, so should be safe to switch to the new chain of drm_bridge API > unconditionally. > > The patches has been tested on a Acer Chromebook R13 (Elm) running a > Chrome OS userspace and checking that the valid EDID mode reported by > the bridge is selected. > > Changes in v4: > - Remove double call to drm_encoder_init(). (Chun-Kuang Hu) > - Cleanup the encoder in mtk_dsi_unbind(). (Chun-Kuang Hu) > > Changes in v3: > - Replace s/bridge/next bridge/ for comment. (Laurent Pinchart) > - Add the bridge.type. (Laurent Pinchart) > - Use next_bridge field to store the panel bridge. (Laurent Pinchart) > - Add the bridge.type field. (Laurent Pinchart) > - This patch requires https://lkml.org/lkml/2020/4/16/2080 to work > properly. > - Move the bridge.type line to the patch that adds drm_bridge support. (Laurent Pinchart) > > Changes in v2: > - Do not set connector_type for panel here. (Sam Ravnborg) > > Enric Balletbo i Serra (7): > drm/bridge: ps8640: Get the EDID from eDP control > drm/bridge_connector: Set default status connected for eDP connectors > drm/mediatek: mtk_dsi: Rename bridge to next_bridge > drm/mediatek: mtk_dsi: Convert to bridge driver > drm/mediatek: mtk_dsi: Use simple encoder > drm/mediatek: mtk_dsi: Use the drm_panel_bridge API > drm/mediatek: mtk_dsi: Create connector for bridges Patch seems ready to apply. Will they be applied to a mediatek tree or to drm-misc-next? Or shall we take the first two patches via drm-misc-next, and the remaning via a mediatek tree? (I hope not) Sam > > drivers/gpu/drm/bridge/parade-ps8640.c | 12 ++ > drivers/gpu/drm/drm_bridge_connector.c | 1 + > drivers/gpu/drm/mediatek/mtk_dsi.c | 269 ++++++++----------------- > 3 files changed, 97 insertions(+), 185 deletions(-) > > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel