From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, inux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, sibis@codeaurora.org,
vinod.koul@linaro.org, agross@kernel.org, ohad@wizery.com,
p.zabel@pengutronix.de, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error
Date: Sun, 21 Jun 2020 00:40:03 -0700 [thread overview]
Message-ID: <20200621074003.GJ128451@builder.lan> (raw)
In-Reply-To: <20200617065658.27567-1-naresh.kamboju@linaro.org>
On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:
> This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
>
> Build error:
> ../drivers/remoteproc/qcom_q6v5_mss.c:
> In function ‘q6v5_mpss_init_image’:
> ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
> error: implicit declaration of function ‘kfree’;
> did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> 772 | kfree(metadata);
> | ^~~~~
> | vfree
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Thanks for the patch Naresh, it looks correct but I've not seen this
build error myself. Could you please let me know what you built to get
this and if you have any suggestion on what caused it? (So we can add a
Fixes: tag etc)
Regards,
Bjorn
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b6a2..903b2bb97e12 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -26,6 +26,7 @@
> #include <linux/reset.h>
> #include <linux/soc/qcom/mdt_loader.h>
> #include <linux/iopoll.h>
> +#include <linux/slab.h>
>
> #include "remoteproc_internal.h"
> #include "qcom_common.h"
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-06-21 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 6:56 [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error Naresh Kamboju
2020-06-17 13:49 ` Naresh Kamboju
2020-06-21 7:40 ` Bjorn Andersson [this message]
2020-06-22 6:18 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621074003.GJ128451@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=inux-remoteproc@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=sibis@codeaurora.org \
--cc=vinod.koul@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox