From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>, Peng Ma <peng.ma@nxp.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Wolfram Sang <wsa@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [PATCH v4 4/4] spi: spi-fsl-dspi: Initialize completion before possible interrupt
Date: Mon, 22 Jun 2020 13:05:43 +0200 [thread overview]
Message-ID: <20200622110543.5035-4-krzk@kernel.org> (raw)
In-Reply-To: <20200622110543.5035-1-krzk@kernel.org>
The interrupt handler calls completion and is IRQ requested before the
completion is initialized. Logically it should be the other way.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v2:
1. None
Changes since v1:
1. Rework the commit msg.
---
drivers/spi/spi-fsl-dspi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index e0b30e4b1b69..91c6affe139c 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -1389,6 +1389,8 @@ static int dspi_probe(struct platform_device *pdev)
goto poll_mode;
}
+ init_completion(&dspi->xfer_done);
+
ret = request_threaded_irq(dspi->irq, dspi_interrupt, NULL,
IRQF_SHARED, pdev->name, dspi);
if (ret < 0) {
@@ -1396,8 +1398,6 @@ static int dspi_probe(struct platform_device *pdev)
goto out_clk_put;
}
- init_completion(&dspi->xfer_done);
-
poll_mode:
if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) {
--
2.17.1
next prev parent reply other threads:[~2020-06-22 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 11:05 [PATCH v4 1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer Krzysztof Kozlowski
2020-06-22 11:05 ` [PATCH v4 2/4] spi: spi-fsl-dspi: Fix lockup if device is shutdown " Krzysztof Kozlowski
2020-06-22 11:17 ` Vladimir Oltean
2020-06-22 11:05 ` [PATCH v4 3/4] spi: spi-fsl-dspi: Fix external abort on interrupt in resume or exit paths Krzysztof Kozlowski
2020-06-22 11:17 ` Vladimir Oltean
2020-06-22 11:05 ` Krzysztof Kozlowski [this message]
2020-06-22 11:17 ` [PATCH v4 1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer Vladimir Oltean
2020-06-22 14:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622110543.5035-4-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peng.ma@nxp.com \
--cc=vladimir.oltean@nxp.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox