RE: [PATCH 0/3] Use MFD for Dallas/Maxim DS1374 driver series

Johnson CH Chen (陳昭勳)
2020-06-23T03:20:06Z

Hi,
>
> Hi,
>
> On 22/06/2020 10:03:25+0000, Johnson CH Chen (陳昭勳) wrote:
> > Hello all,
> >
> > This patch set uses MFD structure for DS1374 so that RTC and Watchdog
> > functions can be separately. Therefore, we can add more Watchdog
> > subfunctions here.
> >
> > A DS1374 MFD core driver supports the I2C communication to RTC and
> > Watchdog devices.
> >
> > 1. Add DS1374 MFD core driver with I2C bus.
> > 2. Let DS1374 RTC driver has RTC and Alarm functions only.
> > 3. Add DS1374 Watchdog driver.
> >
>
> For reference, this was the last attempt:
>
> https://lore.kernel.org/linux-rtc/20170718092245.tc5oosbbb6lzvqpy@dell/
>
> The main issue I see with your series is that there is no way to select which of
> the rtc or the watchdog driver has to be used as IIRC each function is mutually
> exclusive. I think you should work on the DT bindings, addressing the few
> remaining comments.
>
Thanks for your review and good suggestion!
Usage of rtc and watchdog should be defined in DT binding if we want to keep
them separate.

I'll work towards these later.

> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Best regards,
Johnson