From: Peter Zijlstra <peterz@infradead.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
Date: Mon, 22 Jun 2020 14:27:08 +0200 [thread overview]
Message-ID: <20200622122708.GB576871@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200622121116.GD4151@kadam>
On Mon, Jun 22, 2020 at 03:11:17PM +0300, Dan Carpenter wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.06.17a
> head: d3779e78b9848a707448dbb4a0cb6c4bb651fe9c
> commit: 59a5d883f2ccdce1700862b5983cfd3473630aea [35/38] EXP sched: Alleged fix for v5.8 merge-window scheduler issue
> config: x86_64-randconfig-m001-20200621 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu'.
>
> # https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?id=59a5d883f2ccdce1700862b5983cfd3473630aea
> git remote add rcu https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> git remote update rcu
> git checkout 59a5d883f2ccdce1700862b5983cfd3473630aea
> vim +/cpu +2650 kernel/sched/core.c
>
> ^1da177e4c3f41 kernel/sched.c Linus Torvalds 2005-04-16 2644
> b5179ac70de85e kernel/sched/core.c Peter Zijlstra 2016-05-11 2645 ttwu_queue(p, cpu, wake_flags);
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 2646 unlock:
> 013fdb8086acaa kernel/sched.c Peter Zijlstra 2011-04-05 2647 raw_spin_unlock_irqrestore(&p->pi_lock, flags);
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 2648 out:
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 2649 if (success)
> aacedf26fb7601 kernel/sched/core.c Peter Zijlstra 2019-06-07 @2650 ttwu_stat(p, cpu, wake_flags);
> ^^^
> This can be uninitialized on a couple "goto unlock;" paths. Lines
> 2581 and 2622. The KASan tool will warn about this at run time as well.
> I'm not sure why the build bot doesn't include the whole function for
> this bug report...
Indeed, lemme go fix.
prev parent reply other threads:[~2020-06-22 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 12:11 [rcu:dev.2020.06.17a 35/38] kernel/sched/core.c:2650 try_to_wake_up() error: uninitialized symbol 'cpu' Dan Carpenter
2020-06-22 12:27 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622122708.GB576871@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox