From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 564A7C433E0 for ; Mon, 22 Jun 2020 14:44:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30B5A20732 for ; Mon, 22 Jun 2020 14:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592837050; bh=JeM2k9LZLGwMR+rmDIhVvU3owb+bFfdgnMZMKkzslrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=oiZ6xjfkOUeDYOK3PBz6YuK5n5j0NyLPl92420900Hwyi0ThkRGsUBlH84DCcDs07 6Ky1bBa4xlkL5eWtWukVkxyD0XOG85JEn3j91fokoCm/1vfhFu/qesEkxvqbvGBaxk mrYCLT/A8l7Z5/4ZF66lf/ZOsBx77x26DG51aTdM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729206AbgFVOoI (ORCPT ); Mon, 22 Jun 2020 10:44:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:46786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728293AbgFVOoI (ORCPT ); Mon, 22 Jun 2020 10:44:08 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B6882071A; Mon, 22 Jun 2020 14:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592837047; bh=JeM2k9LZLGwMR+rmDIhVvU3owb+bFfdgnMZMKkzslrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DVP6gqnRjQLHKC8DyHJyDDhVgNrgyP7tjiARScsm0+Ali1+lbF0WmxaCZRJEZ/W0T 7KtBPBkSc5xg2Kw8ElBdyJEQJDTJ/vJyzGNDjYZOfV1a0V0Fb0Lh2yccrMwVfkjdRI E61BP9sHdlb3k1/t5dMbp1wO+rzGMnq9dvO+4njo= Date: Mon, 22 Jun 2020 10:44:02 -0400 From: Sasha Levin To: Mark Brown Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dmitry Osipenko , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.7 004/388] ASoC: tegra: tegra_wm8903: Support nvidia, headset property Message-ID: <20200622144402.GH1931@sasha-vm> References: <20200618010805.600873-1-sashal@kernel.org> <20200618010805.600873-4-sashal@kernel.org> <20200618110023.GB5789@sirena.org.uk> <20200618143046.GT1931@sasha-vm> <20200618143930.GI5789@sirena.org.uk> <20200621233352.GA1931@sasha-vm> <20200622112321.GB4560@sirena.org.uk> <20200622123118.GF1931@sasha-vm> <20200622132757.GG4560@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200622132757.GG4560@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 02:27:57PM +0100, Mark Brown wrote: >On Mon, Jun 22, 2020 at 08:31:18AM -0400, Sasha Levin wrote: >> On Mon, Jun 22, 2020 at 12:23:21PM +0100, Mark Brown wrote: > >> > That's concerning - please don't do this. It's not what stable is >> > expected to be and there's no guarantee that you're getting all the >> > changes required to actually make things work. > >> How come? This is one of the things stable rules explicitly call for: >> "New device IDs and quirks are also accepted". > >I would expect that to be data only additions, I would not expect that >to be adding new code. These come hand in hand. Take a look at the more complex cases such as sound/pci/hda/patch_* >> If we're missing anything, the solution is to make sure we stop missing >> it rather than not take anything to begin with :) > >It would be much better to not have to watch stable constantly like we >currently do - we're seeing people report breakage often enough to be a >concern as things are, we don't need to be trying to pile extra stuff in >there because there's some keywords in a changelog or whatever. The >testing coverage for drivers is weak, increasing the change rate puts >more stress on that. Shouldn't we instead improve testing here? nvidia for example already provides Tegra testing for stable releases, if the coverage isn't sufficient then let's work on making it better. -- Thanks, Sasha