From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Maulik Shah <mkshah@codeaurora.org>,
agross@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
rnayak@codeaurora.org, ilina@codeaurora.org,
lsrao@codeaurora.org, john.stultz@linaro.org
Subject: Re: [PATCH] soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag
Date: Mon, 22 Jun 2020 12:29:32 -0700 [thread overview]
Message-ID: <20200622192932.GV128451@builder.lan> (raw)
In-Reply-To: <159281658960.62212.15968925558324290917@swboyd.mtv.corp.google.com>
On Mon 22 Jun 02:03 PDT 2020, Stephen Boyd wrote:
> Quoting Maulik Shah (2020-06-21 23:53:25)
> > rpmh-rsc driver is fairly core to system and should not be removable
> > once its probed. However it allows to unbind driver from sysfs using
> > below command which results into a crash on sc7180.
>
> What is the crash? The world falls apart because rpmh APIs start
> referencing pointers that point to freed memory?
>
Presumably the devm_of_platform_populate() will cause said drivers to be
dismantled as well - but I think it's safe to say that that code path
isn't well tested...
I've applied the patch, but would have preferred that some time was
spent to make sure that things are unloadable as well.
Regards,
Bjorn
> >
> > echo 18200000.rsc > /sys/bus/platform/drivers/rpmh/unbind
> >
> > Lets prevent unbind at runtime by setting suppress_bind_attrs flag.
>
> Ok. But when the Android module brigade comes knocking they'll have to
> revert this change and solve this problem too. Have fun!
>
> >
> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
prev parent reply other threads:[~2020-06-22 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 6:53 [PATCH] soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag Maulik Shah
2020-06-22 9:03 ` Stephen Boyd
2020-06-22 11:39 ` Maulik Shah
2020-06-22 19:29 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622192932.GV128451@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dianders@chromium.org \
--cc=ilina@codeaurora.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox