From: Matthew Wilcox <willy@infradead.org>
To: Egor Chelak <egor.chelak@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] isofs: fix High Sierra dirent flag accesses
Date: Mon, 22 Jun 2020 22:22:45 +0100 [thread overview]
Message-ID: <20200622212245.GC21350@casper.infradead.org> (raw)
In-Reply-To: <20200621040817.3388-1-egor.chelak@gmail.com>
On Sun, Jun 21, 2020 at 07:08:17AM +0300, Egor Chelak wrote:
> The flags byte of the dirent was accessed as de->flags[0] in a couple of
> places, and not as de->flags[-sbi->s_high_sierra], which is how it's
> accessed elsewhere. This caused a bug, where some files on an HSF disc
> could be inaccessible.
> +++ b/fs/isofs/dir.c
> @@ -50,6 +50,7 @@ int isofs_name_translate(struct iso_directory_record *de, char *new, struct inod
> int get_acorn_filename(struct iso_directory_record *de,
> char *retname, struct inode *inode)
> {
> + struct isofs_sb_info *sbi = ISOFS_SB(inode->i_sb);
> int std;
> unsigned char *chr;
> int retnamlen = isofs_name_translate(de, retname, inode);
> @@ -66,7 +67,7 @@ int get_acorn_filename(struct iso_directory_record *de,
> return retnamlen;
> if ((*retname == '_') && ((chr[19] & 1) == 1))
> *retname = '!';
> - if (((de->flags[0] & 2) == 0) && (chr[13] == 0xff)
> + if (((de->flags[-sbi->s_high_sierra] & 2) == 0) && (chr[13] == 0xff)
> && ((chr[12] & 0xf0) == 0xf0)) {
> retname[retnamlen] = ',';
> sprintf(retname+retnamlen+1, "%3.3x",
It's been about 22 years since I contributed the patch which added
support for the Acorn extensions ;-) But I'm pretty sure that it's not
possible to have an Acorn CD-ROM that is also an HSF CD-ROM. That is,
all Acorn formatted CD-ROMs are ISO-9660 compatible. So I think this
chunk of the patch is not required.
next prev parent reply other threads:[~2020-06-22 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 4:08 [PATCH] isofs: fix High Sierra dirent flag accesses Egor Chelak
2020-06-22 21:22 ` Matthew Wilcox [this message]
2020-06-23 1:21 ` Egor Chelak
2020-06-22 21:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622212245.GC21350@casper.infradead.org \
--to=willy@infradead.org \
--cc=arnd@arndb.de \
--cc=egor.chelak@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox