From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68124C433DF for ; Tue, 23 Jun 2020 01:19:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4178120720 for ; Tue, 23 Jun 2020 01:19:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="AnagMKzr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731860AbgFWBTn (ORCPT ); Mon, 22 Jun 2020 21:19:43 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:55052 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731667AbgFWBTm (ORCPT ); Mon, 22 Jun 2020 21:19:42 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C361327; Tue, 23 Jun 2020 03:19:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1592875180; bh=A1BPBP7IBhvl06oo1JVRf8zGahYeO6mzOQ68hxqYL4U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AnagMKzrYkDtq6thkbxOVWtLV7eZh5FUbo8aY4leF4Z9ZmKdur1cCWCcBeubE591X x+VYQwOnk9B04PTlgxtbrU3NbAQntb7L/LGNbhr23EP5y7Mt0L70qxrqKAGpfdBKNC lAwhsag/fbjrQnRaPcty8A/vV7/y5mhrFHCrtxu8= Date: Tue, 23 Jun 2020 04:19:15 +0300 From: Laurent Pinchart To: Nathan Chancellor Cc: Andrew Morton , Mauro Carvalho Chehab , Arnd Bergmann , Christoph Hellwig , Geert Uytterhoeven , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 1/2] media: omap3isp: Remove cacheflush.h Message-ID: <20200623011915.GP5852@pendragon.ideasonboard.com> References: <20200622234740.72825-1-natechancellor@gmail.com> <20200622234740.72825-2-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200622234740.72825-2-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nathan, Thank you for the patch. On Mon, Jun 22, 2020 at 04:47:39PM -0700, Nathan Chancellor wrote: > After mm.h was removed from the asm-generic version of cacheflush.h, > s390 allyesconfig shows several warnings of the following nature: > > In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, > from drivers/media/platform/omap3isp/isp.c:42: > ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' > declared inside parameter list will not be visible outside of this > definition or declaration > > As Geert and Laurent point out, this driver does not need this header in > the two files that include it. Remove it so there are no warnings. > > Fixes: e0cf615d725c ("asm-generic: don't include in cacheflush.h") > Suggested-by: Geert Uytterhoeven > Suggested-by: Laurent Pinchart > Signed-off-by: Nathan Chancellor Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/omap3isp/isp.c | 2 -- > drivers/media/platform/omap3isp/ispvideo.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index a4ee6b86663e..b91e472ee764 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -39,8 +39,6 @@ > * Troy Laramy > */ > > -#include > - > #include > #include > #include > diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c > index 10c214bd0903..1ac9aef70dff 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -18,7 +18,6 @@ > #include > #include > #include > -#include > > #include > #include > > base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821 -- Regards, Laurent Pinchart