Re: [RFC 3/7] media: uapi: h264: clarify pic_order_cnt_bit_size field

Nicolas Dufresne
2020-06-25T15:06:46Z

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

Le mardi 23 juin 2020 à 15:28 -0300, Ezequiel Garcia a écrit :
> From: Philipp Zabel <p.zabel@pengutronix.de>
>
> Since pic_order_cnt_bit_size is not a syntax element itself, explicitly
> state that it is the total size in bits of the pic_order_cnt_lsb,
> delta_pic_order_cnt_bottom, delta_pic_order_cnt[0], and
> delta_pic_order_cnt[1] syntax elements contained in the slice.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> [Ezequiel: rebase]
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> index 7af12447a5b0..0808a36777b6 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst
> @@ -1813,7 +1813,9 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> - Size in bits of the dec_ref_pic_marking() syntax element.
> * - __u32
> - ``pic_order_cnt_bit_size``
> - -
> + - Combined size in bits of the picture order count related syntax
> + elements: pic_order_cnt_lsb, delta_pic_order_cnt_bottom,
> + delta_pic_order_cnt0, and delta_pic_order_cnt1.
> * - __u8
> - ``cabac_init_idc``
> -

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]