From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05126C433DF for ; Tue, 23 Jun 2020 20:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D31E720656 for ; Tue, 23 Jun 2020 20:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945873; bh=AouxK48LHagOxXDW5ZoWJtQ+wZKdrPbBpORtCah5Wq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MoHpjsVAEn1zIQEl4WAvSoyF9ey/l6ikUR15vIiprhL62XCDDLdF4OLRnp9vrc5MJ GQZHHt3KSWup0dDPnTFZnD/zcnNZWIxTfay+1NeIH8FLSSIk1QbxZQQexgM6UyujA3 Zz8Fi73TVR+uEtGrZdTV20Q88vhuzRdl7PuydZyw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404210AbgFWU5w (ORCPT ); Tue, 23 Jun 2020 16:57:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:38992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390228AbgFWUm3 (ORCPT ); Tue, 23 Jun 2020 16:42:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0D022078A; Tue, 23 Jun 2020 20:42:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944949; bh=AouxK48LHagOxXDW5ZoWJtQ+wZKdrPbBpORtCah5Wq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mRt8HgJ4JG26PACKxSSz6JftzZkxgwFiGJnqsvNG25DB1L39e/tXLRK81r97Pms6Z cYGmdyZATf9P8HeGjmrWjbycexXYnsxqS3F5hyH4i7qIhmkgq3EWu8R61jk0sMYgj7 a/BLXO+D2BqMGEnCKPdmT3Yp2TB6ycjkEf0dYGts= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.19 187/206] mtd: rawnand: xway: Fix the probe error path Date: Tue, 23 Jun 2020 21:58:35 +0200 Message-Id: <20200623195326.235589162@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miquel Raynal [ Upstream commit 34531be5e804a8e1abf314a6c3a19fe342e4a154 ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-61-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/raw/xway_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/xway_nand.c b/drivers/mtd/nand/raw/xway_nand.c index 1adb41acebfc3..bfa43fdc3c541 100644 --- a/drivers/mtd/nand/raw/xway_nand.c +++ b/drivers/mtd/nand/raw/xway_nand.c @@ -211,7 +211,7 @@ static int xway_nand_probe(struct platform_device *pdev) err = mtd_device_register(mtd, NULL, 0); if (err) - nand_release(&data->chip); + nand_cleanup(&data->chip); return err; } -- 2.25.1