From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15DD1C433E0 for ; Wed, 24 Jun 2020 14:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF3CD20738 for ; Wed, 24 Jun 2020 14:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LdqUQaQQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391097AbgFXOlU (ORCPT ); Wed, 24 Jun 2020 10:41:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389836AbgFXOlT (ORCPT ); Wed, 24 Jun 2020 10:41:19 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19457C0613ED for ; Wed, 24 Jun 2020 07:41:19 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d12so1150259ply.1 for ; Wed, 24 Jun 2020 07:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Fbp7umasnXh+ke7N+beUAyOfPReUM2Tp6A+dzgB7eMs=; b=LdqUQaQQ73lvg2EH4zB5b0fAHY6pDsTgO5VkTlBIIFPTWFDt6KEfeGjsb0w6+bZ9Ow NITWE6F0NiNBcydTH1X5G5v/4LVNjJl2xkptnKSgFVRZwIBSdg7/4DIa9E/LMGsAb6fD enidR4CvnWPaAtnjb4zwOOo4tT4QsgRPZnifk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fbp7umasnXh+ke7N+beUAyOfPReUM2Tp6A+dzgB7eMs=; b=YRxNt/O6/dKTAetJjwWlcRe+IsnX8+2QCs3/P9eLKkH7Yx/lcfqNyHVXi8RRzEns7R IgRS4d/I4vs9b4geEE1Jf/lNRSDKHSCXvb5RhEIfJo93CtBKBqgOB/lWeROBWKzJemJK C84deZpQehzxwsfndKdIHcnxUUbG51WTPsehiTv1epcFu7yCTwGiUO+hHEutABKQGzPj tUg1AlF/PYLW9CXqLfyG/9bpMRsnto1flseflu0og3Kq3Zf6HYY6w8qPlyFKBG95y4fF +BoWS7mSbtgson9O13iblMbm06haI34Ia5N4qL59fC88I76dDTaQOLwoyXQd6ME98mk1 rZgA== X-Gm-Message-State: AOAM532iEixbcgt3tVcMalZh2jGaYUZ6g0jcBrtqEZhGeEAexlEcCv67 Eg2RvkGIerTBeZ/qFuVC37K+dg== X-Google-Smtp-Source: ABdhPJyLzb6qwq/8MBqHXf8uzinIy/tV8mWrOCrHPE7Fwn5qlWt9b5nzHsWE+x0soPiCSmy2JH0LLA== X-Received: by 2002:a17:90a:7185:: with SMTP id i5mr2257473pjk.175.1593009678562; Wed, 24 Jun 2020 07:41:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s23sm15899769pfs.157.2020.06.24.07.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 07:41:17 -0700 (PDT) Date: Wed, 24 Jun 2020 07:41:16 -0700 From: Kees Cook To: Alexander Popov Cc: Luis Chamberlain , Jann Horn , Emese Revfy , Miguel Ojeda , Masahiro Yamada , Michal Marek , Andrew Morton , Masahiro Yamada , Thiago Jung Bauermann , Jessica Yu , Sven Schnelle , Iurii Zaikin , Catalin Marinas , Will Deacon , Vincenzo Frascino , Thomas Gleixner , Peter Collingbourne , Naohiro Aota , Alexander Monakov , Mathias Krause , PaX Team , Brad Spengler , Laura Abbott , Florian Weimer , kernel-hardening@lists.openwall.com, linux-kbuild@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gcc@gcc.gnu.org, notify@kernel.org Subject: Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter Message-ID: <202006240740.5AF6369E53@keescook> References: <20200624123330.83226-1-alex.popov@linux.com> <20200624123330.83226-6-alex.popov@linux.com> <20200624125305.GG4332@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote: > On 24.06.2020 15:53, Luis Chamberlain wrote: > > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > >> Add 'verbose' plugin parameter for stackleak gcc plugin. > >> It can be used for printing additional info about the kernel code > >> instrumentation. > >> > >> For using it add the following to scripts/Makefile.gcc-plugins: > >> gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \ > >> += -fplugin-arg-stackleak_plugin-verbose > > > > Would be nice if we instead could pass an argument to make which lets > > us enable this. > > This feature is useful only for debugging stackleak gcc plugin. > > The cflag that enables it is similar to -fplugin-arg-structleak_plugin-verbose, > which is used for debugging the structleak plugin. > > This debugging feature clutters the kernel build output, I don't think that many > people will use it. So IMO creating a separate argument for make is not really > needed. Yup, agreed. The precedent for plugin verbosity is via CONFIGs. They're not really general purpose enough to justify a "make" argument. -- Kees Cook