From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534BBC433E1 for ; Wed, 24 Jun 2020 20:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 350DF2080C for ; Wed, 24 Jun 2020 20:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y1j+29kx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391470AbgFXUgL (ORCPT ); Wed, 24 Jun 2020 16:36:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729833AbgFXUgJ (ORCPT ); Wed, 24 Jun 2020 16:36:09 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60312C061573 for ; Wed, 24 Jun 2020 13:36:09 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id k1so1588600pls.2 for ; Wed, 24 Jun 2020 13:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pgO1m61KHUuX3PlQgWsNmv+WwHbeWP7bfAQiG1GvUW4=; b=Y1j+29kxJwpJ0aEr6u3wsVIF8qsGWpyiGBvwKiy5HrXYgpRLcw4DAwK7vLtdyYiB3M qKxtyyX2XoWDyIEouUtcKSby8ACCDJYMT1BqlNQEz9sC9V9QMOm19BQgZKPw2sJgX8eo lR2lzjXyG0E/LHiNV332oFq+AvlgY8bV9i8g0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pgO1m61KHUuX3PlQgWsNmv+WwHbeWP7bfAQiG1GvUW4=; b=FxOQExsLXGEyI1Gr1z9Ko3GnZIo282nftKNJ22MbY1ndU7UqOOaUnOHrPHp3JWp0tq YO+03+APuO394fP3kTmfGLNO05L3pQK90eiAm1j7L9viB/k1egv21gHSWiAiZQlmp9GO XVR5GVALZ4I7GciF3yRrBgZzFNkpUwRY+FaJJyli2LjBSWjH+UZ9uAHlqOKKMP8M5NiT AagHvKDCEjrIsGKRfCSs5dAVLyd0/4xbmVi5uVu+6RM9iBP43zF7Lhx6/fjwqhlmGjI8 YXkqzgh+rZMLK5dVkdOlFzJ69rfHk+Vco7QUf0fg0mUmuQ2y7KkkOhbFKj/bYHA+BF9g nIjg== X-Gm-Message-State: AOAM531MOWGbxK1eWG9v0aqeIN+xYU8Lu0MX3MmXHEknfim3s/Ex4pgO +hGLBhbqExOyQu9gTpY6o4RVSA== X-Google-Smtp-Source: ABdhPJxQnUOr0rPh83NgE/X2mffcJAt0WerGIXvgcy2ZVvS/CVDjKXX+PoSM4O3Z+h3Uoytd2NTvrg== X-Received: by 2002:a17:90a:55c7:: with SMTP id o7mr27620634pjm.205.1593030968933; Wed, 24 Jun 2020 13:36:08 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j19sm20510490pfn.109.2020.06.24.13.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 13:36:08 -0700 (PDT) Date: Wed, 24 Jun 2020 13:36:07 -0700 From: Kees Cook To: Richard Weinberger Cc: Randy Dunlap , Greg Kroah-Hartman , Prasad Sodagudi , Sami Tolvanen , Amit Daniel Kachhap , linux-kselftest@vger.kernel.org, clang-built-linux@googlegroups.com, linux-kernel , Richard Weinberger Subject: Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups Message-ID: <202006241335.2C0FB5DF90@keescook> References: <20200529200347.2464284-1-keescook@chromium.org> <202006231610.4993DC5@keescook> <2356a78c-750b-538f-3d64-b9c78aff89cb@infradead.org> <903628180.54697.1592983405305.JavaMail.zimbra@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <903628180.54697.1592983405305.JavaMail.zimbra@nod.at> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 24, 2020 at 09:23:25AM +0200, Richard Weinberger wrote: > ----- Ursprüngliche Mail ----- > >>> Regardless, it seems arch/x86/um/asm/desc.h is not needed any more? > > > >> True that, we can rip the file. > > > > Has anyone fixed the uml build errors? > > I didn't realize that this is a super urgent issue. ;-) > > Kees, if you want you can carry a patch in your series, I'll ack it. > Otherwise I can also do a patch and bring it via the uml tree upstream > as soon more fixes queued up. I think the lkdtm change will tweak this bug, so I'm happy to carry the patch (I just haven't had time to create and test one). Is it really just as simple as removing arch/x86/um/asm/desc.h? -- Kees Cook