From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8594C433E0 for ; Wed, 24 Jun 2020 18:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B726C206C0 for ; Wed, 24 Jun 2020 18:16:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PACeauBn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406041AbgFXSQM (ORCPT ); Wed, 24 Jun 2020 14:16:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406031AbgFXSQJ (ORCPT ); Wed, 24 Jun 2020 14:16:09 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A780C061573 for ; Wed, 24 Jun 2020 11:16:09 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id q5so3213213wru.6 for ; Wed, 24 Jun 2020 11:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=vEE+cCagyynmemrGijLPmssYwIESzMX1SE4z58oNTeY=; b=PACeauBnHB4IRAwpME1nagEtAloxPaEYhO3RZGIWA7WpWs7UdpRkFrhqwK/38eXKTb MgA2rC99nTXO06aJaeKtqBQ4hQMH3xG5mO0Vh7a1FKb85qhPoNfUlrvF01dqO8t8WHXO B95BQDfyO/W7VSp0hmOZMRqNqf/zkVRJfafF6sgpHgzRLMeYHsPc6cQg/hd95Z6u1FAC UerFlmDKk9lqHRVyfJ9Kz7Im84N+ZJ1HmbS613LAP3J9y6RlznzczX12e8iHtYY/SkJI tGzMtxp/MOx0DztQ1Eag8fw0VrXJczxp0eOzRhC04c2i0UgUSVHFM+haxW2KibpbW/jr dZxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vEE+cCagyynmemrGijLPmssYwIESzMX1SE4z58oNTeY=; b=TymzSKZIA84ysiOfIV13vJjp2wBqc92ZvoVD5AptkA1dK7J4CdrXAhWFfJx76mptRx oNlVH0j2aczBnWj9INZUP0lwUIw8Z5oWJsrZooFrzcQyuYdNTz0r4pG6K1JhufeqFj7y 6whLjfH3RCuFgLE3KSmE6B9tqSQ6jC/oPglTtdh1yFRgnGwKeBYse6+yl0ODCIqya5Le WDAWMevdnU0CBQr6sN7RF/MPKYdzUIlUuQ0GmEvLuCvlqZGRWgoCRunQNw3qJm+KhDTp 1YN5uC/G57iGL0VJLga9EOWUGcMOX/+nwLBNWboiCUBUbHikZN/hCx7b8cPWaHKx+u3+ jdIw== X-Gm-Message-State: AOAM533iRUO25Hd2z7Q4APbqDnWtupps8TzmzQlrMMMPPwllLW8K/NCl p6uljG3o41WGQ181fqfUtOMFOQ== X-Google-Smtp-Source: ABdhPJwthKa+x+ZDgO4Y76Lis50CaKMXrmW51/0dmqQgM1NpqUQmeO/Npa89EkAARjUX45u5QLZqgg== X-Received: by 2002:adf:e90d:: with SMTP id f13mr3152153wrm.146.1593022568188; Wed, 24 Jun 2020 11:16:08 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id 2sm8962784wmo.44.2020.06.24.11.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 11:16:07 -0700 (PDT) Date: Wed, 24 Jun 2020 19:16:05 +0100 From: Lee Jones To: Masahiro Yamada Cc: linux-arm-kernel , Rob Herring , DTML , Linux Kernel Mailing List Subject: Re: [PATCH 4/4] ARM: dts: uniphier: change support card to simple-mfd from simple-bus Message-ID: <20200624181605.GJ954398@dell> References: <20200623114614.792648-1-yamada.masahiro@socionext.com> <20200623114614.792648-4-yamada.masahiro@socionext.com> <20200623122413.GA954398@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jun 2020, Masahiro Yamada wrote: > On Tue, Jun 23, 2020 at 9:24 PM Lee Jones wrote: > > > > On Tue, 23 Jun 2020, Masahiro Yamada wrote: > > > > > 'make ARCH=arm dtbs_check' emits the following warning: > > > > > > support-card@1,1f00000: $nodename:0: 'support-card@1,1f00000' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > > > > Maybe, simple-mfd could be a better fit for this device. > > > > The two should be equivalent. > > Yes, I know. > That's why I can change "simple-bus" to "simple-mfd" > with no risk. > > The difference is schema-check. > > The node name for "simple-bus" is checked by 'make dtbs_check'. > > See this code: > https://github.com/robherring/dt-schema/blob/v2020.05/schemas/simple-bus.yaml#L17 > > Even if I rename the node, it does not accept the > unit name '1,1f00000' > > > What do you mean by "maybe"? Does this squash the warning? > > "maybe" means I am not quite sure > which compatible is a better fit > to describe this device. > > As mentioned above, simple-bus and simple-mfd > are interchangeable from a driver point of view. > > This add-on board is integrated with various peripherals > such as 16550a serial, smsc9115 ether etc. > The address-decode is implemented in a CPLD device. > It has chip selects and local addresses, which are mapped to > the parent. > > It can be either simple-bus or simple-mfd, I think. > > > dt-schema checks the node name of simple-bus. > Currently, there is no check for simple-mfd. > > So, I think this patch is an easy solution > to fix the warning. Yes, looking at the documentation it seems as though 'simple-mfd' would be a better fit. Is the device a single IP with various different functions? > Rob is in Cc. Please add comments if any. > > > Isn't the issue caused by the ','? > > Right. > > The node name of simple-bus > must meet the regular expression: > "^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$" > > > Even if I rename the node > "support-card@1,1f00000" > to "bus@1,1f00000", the warning is still > displayed due to ',' > > "1,1f00000" means > the address 0x01f00000 of chip select 1. Is this an officially accepted format? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog