From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 09/13] perf stat: implement control commands handling
Date: Thu, 25 Jun 2020 14:14:53 +0200 [thread overview]
Message-ID: <20200625121453.GH2719003@krava> (raw)
In-Reply-To: <5d6bab4b-d743-609e-e08c-8eabcb9adfef@linux.intel.com>
On Wed, Jun 24, 2020 at 05:10:10PM +0300, Alexey Budankov wrote:
>
> On 23.06.2020 17:54, Jiri Olsa wrote:
> > On Wed, Jun 17, 2020 at 11:41:30AM +0300, Alexey Budankov wrote:
> >
> > SNIP
> >
> >>
> >> while (1) {
> >> if (forks)
> >> @@ -581,8 +617,17 @@ static int dispatch_events(bool forks, int timeout, int interval, int *times, st
> >> if (done || stop || child)
> >> break;
> >>
> >> - nanosleep(ts, NULL);
> >> - stop = process_timeout(timeout, interval, times);
> >> + clock_gettime(CLOCK_MONOTONIC, &time_start);
> >> + if (!(evlist__poll(evsel_list, time_to_sleep) > 0)) { /* poll timeout or EINTR */
> >> + stop = process_timeout(timeout, interval, times);
> >> + time_to_sleep = sleep_time;
> >> + } else { /* fd revent */
> >> + stop = process_evlist(evsel_list, interval, times);
> >> + clock_gettime(CLOCK_MONOTONIC, &time_stop);
> >> + diff_timespec(&time_diff, &time_stop, &time_start);
> >> + time_to_sleep -= time_diff.tv_sec * MSEC_PER_SEC +
> >> + time_diff.tv_nsec / NSEC_PER_MSEC;
> >
> > should we check time_to_sleep > time_diff first?
>
> Probably and if time_diff > time_to_sleep then time_to_sleep = 0 ?
or extra call to process_timeout? if we dont want to call evlist_poll
with 0 timeout
jirka
>
> ~Alexey
>
> >
> > jirka
> >
>
next prev parent reply other threads:[~2020-06-25 12:15 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 8:30 [PATCH v8 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-17 8:35 ` [PATCH v8 01/13] tools/libperf: avoid moving of fds at fdarray__filter() call Alexey Budankov
2020-06-24 17:19 ` Alexey Budankov
2020-06-25 17:14 ` Jiri Olsa
2020-06-25 19:32 ` Alexey Budankov
2020-06-26 9:37 ` Jiri Olsa
2020-06-26 10:06 ` Alexey Budankov
2020-06-29 15:11 ` Alexey Budankov
2020-06-29 19:17 ` Jiri Olsa
2020-06-17 8:35 ` [PATCH v8 02/13] perf evlist: introduce control file descriptors Alexey Budankov
2020-06-17 8:36 ` [PATCH v8 03/13] perf evlist: implement control command handling functions Alexey Budankov
2020-06-23 14:56 ` Jiri Olsa
2020-06-23 15:03 ` Arnaldo Carvalho de Melo
2020-06-23 15:14 ` Jiri Olsa
2020-06-24 13:35 ` Alexey Budankov
2020-06-23 14:56 ` Jiri Olsa
2020-06-24 13:20 ` Alexey Budankov
2020-06-17 8:37 ` [PATCH v8 04/13] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-06-23 14:56 ` Jiri Olsa
2020-06-24 14:27 ` Alexey Budankov
2020-06-25 12:17 ` Jiri Olsa
2020-06-25 16:01 ` Alexey Budankov
2020-06-25 17:13 ` Jiri Olsa
2020-06-25 18:43 ` Alexey Budankov
2020-06-17 8:38 ` [PATCH v8 05/13] perf stat: move target check to loop control statement Alexey Budankov
2020-06-17 8:39 ` [PATCH v8 06/13] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-06-17 8:40 ` [PATCH v8 07/13] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-06-23 14:56 ` Jiri Olsa
2020-06-24 13:27 ` Alexey Budankov
2020-06-17 8:40 ` [PATCH v8 08/13] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-06-17 8:41 ` [PATCH v8 09/13] perf stat: implement control commands handling Alexey Budankov
2020-06-23 14:54 ` Jiri Olsa
2020-06-24 14:10 ` Alexey Budankov
2020-06-25 12:14 ` Jiri Olsa [this message]
2020-06-25 14:58 ` Alexey Budankov
2020-06-23 14:54 ` Jiri Olsa
2020-06-24 13:39 ` Alexey Budankov
2020-06-25 12:12 ` Jiri Olsa
2020-06-25 14:52 ` Alexey Budankov
2020-06-17 8:42 ` [PATCH v8 10/13] perf stat: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-06-17 8:42 ` [PATCH v8 11/13] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-06-17 8:43 ` [PATCH v8 12/13] perf record: implement control commands handling Alexey Budankov
2020-06-23 14:54 ` Jiri Olsa
2020-06-24 14:00 ` Alexey Budankov
2020-06-24 14:55 ` Alexey Budankov
2020-06-25 17:07 ` Jiri Olsa
2020-06-17 8:44 ` [PATCH v8 13/13] perf record: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-06-22 3:38 ` [PATCH v8 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-22 8:55 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625121453.GH2719003@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox