* [PATCH] staging: gasket: Convert symbolic permission to octal
@ 2020-06-25 13:25 Brooke Basile
2020-06-25 13:36 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Brooke Basile @ 2020-06-25 13:25 UTC (permalink / raw)
To: rspringer, toddpoynor, benchan, rcy, gregkh
Cc: devel, linux-kernel, trivial, Brooke Basile
Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
Signed-off-by: Brooke Basile <brookebasile@gmail.com>
---
drivers/staging/gasket/gasket_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
index ab5aa351d555..eb0fd3b0490f 100644
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
#define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
{ \
- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
+ .attr = __ATTR(_name, 0444, _show_function, NULL), \
.data.attr_type = _attr_type \
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: gasket: Convert symbolic permission to octal
2020-06-25 13:25 [PATCH] staging: gasket: Convert symbolic permission to octal Brooke Basile
@ 2020-06-25 13:36 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-06-25 13:36 UTC (permalink / raw)
To: Brooke Basile
Cc: rspringer, toddpoynor, benchan, rcy, devel, trivial, linux-kernel
On Thu, Jun 25, 2020 at 09:25:13AM -0400, Brooke Basile wrote:
> Fixing checkpatch WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
>
> Signed-off-by: Brooke Basile <brookebasile@gmail.com>
> ---
> drivers/staging/gasket/gasket_sysfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
> index ab5aa351d555..eb0fd3b0490f 100644
> --- a/drivers/staging/gasket/gasket_sysfs.h
> +++ b/drivers/staging/gasket/gasket_sysfs.h
> @@ -71,7 +71,7 @@ struct gasket_sysfs_attribute {
>
> #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \
> { \
> - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \
> + .attr = __ATTR(_name, 0444, _show_function, NULL), \
> .data.attr_type = _attr_type \
> }
Someone else sent this a few days before you did:
https://lore.kernel.org/r/20200622073612.12282-1-rodolfovillordo@gmail.com
sorry,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-25 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-25 13:25 [PATCH] staging: gasket: Convert symbolic permission to octal Brooke Basile
2020-06-25 13:36 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox