From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5816C433DF for ; Fri, 26 Jun 2020 01:06:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA43920767 for ; Fri, 26 Jun 2020 01:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726978AbgFZBGJ (ORCPT ); Thu, 25 Jun 2020 21:06:09 -0400 Received: from mga05.intel.com ([192.55.52.43]:16108 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbgFZBGH (ORCPT ); Thu, 25 Jun 2020 21:06:07 -0400 IronPort-SDR: 0Q0q3AHZ6qQoFR8dX8iIc4le0fORJy5OYbglYfgAwPgVT9s53L1A+QfHHxl4kKmASs8hXEZ6W3 OYH0unDkrRJA== X-IronPort-AV: E=McAfee;i="6000,8403,9663"; a="229884387" X-IronPort-AV: E=Sophos;i="5.75,281,1589266800"; d="scan'208";a="229884387" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 18:06:05 -0700 IronPort-SDR: eMKqNd7ps268Mv92AG3KCTkH6vtUFOk49SDyQWHAbB/uppL/oaiRtt2HIbyLiDwH/3dsDLMDpN 4EJi8PbqEPSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,281,1589266800"; d="scan'208";a="311272783" Received: from lkp-server01.sh.intel.com (HELO 538b5e3c8319) ([10.239.97.150]) by orsmga008.jf.intel.com with ESMTP; 25 Jun 2020 18:06:04 -0700 Received: from kbuild by 538b5e3c8319 with local (Exim 4.92) (envelope-from ) id 1jocoe-0001vU-9x; Fri, 26 Jun 2020 01:06:04 +0000 Date: Fri, 26 Jun 2020 09:05:18 +0800 From: kernel test robot To: Antoine Tenart Cc: kbuild-all@lists.01.org, Quentin Schulz , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings Message-ID: <20200626010518.GA6037@890dc296aae1> References: <202006260959.QkSmCdSE%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006260959.QkSmCdSE%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support") CC: Antoine Tenart Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 3f9437c6234d95d96967f1b438a4fb71b6be254d commit: 7d272e63e0979d38a6256108adbe462d621c26c5 [3775/3988] net: phy: mscc: timestamping and PHC support mscc_ptp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/net/phy/mscc/mscc_ptp.c +++ b/drivers/net/phy/mscc/mscc_ptp.c @@ -1493,10 +1493,7 @@ static int __vsc8584_init_ptp(struct phy vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps, &phydev->mdio.dev); - if (IS_ERR(vsc8531->ptp->ptp_clock)) - return PTR_ERR(vsc8531->ptp->ptp_clock); - - return 0; + return PTR_ERR_OR_ZERO(vsc8531->ptp->ptp_clock); } void vsc8584_config_ts_intr(struct phy_device *phydev)