Re: [PATCH 8/9] fs: don't allow kernel reads and writes without iter ops

Matthew Wilcox
2020-06-26T14:08:45Z

On Fri, Jun 26, 2020 at 09:58:35AM +0200, Christoph Hellwig wrote:
> +static void warn_unsupported(struct file *file, const char *op)
> +{
> + char pathname[128], *path;
> +
> + path = file_path(file, pathname, sizeof(pathname));
> + if (IS_ERR(path))
> + path = "(unknown)";
> + pr_warn_ratelimited(
> + "kernel %s not supported for file %s (pid: %d comm: %.20s)\n",
> + op, path, current->pid, current->comm);
> +}
> +

how about just:

pr_warn_ratelimited(
"kernel %s not supported for file %pD4 (pid: %d comm: %.20s)\n",
op, file, current->pid, current->comm);

also, is the pid really that interesting?