From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: B K Karthik <bkkarthik@pesu.pes.edu>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)
Date: Fri, 26 Jun 2020 16:47:18 +0200 [thread overview]
Message-ID: <20200626144718.GA1218319@kroah.com> (raw)
In-Reply-To: <a9efda13-4425-8cb0-5854-8421f6c14181@xs4all.nl>
On Fri, Jun 26, 2020 at 04:36:52PM +0200, Hans Verkuil wrote:
> On 26/06/2020 16:32, B K Karthik wrote:
> > fixing ERROR: space prohibited before that ',' (ctx:WxW)
> >
> > Signed-off-by: B K Karthik <karthik.bk2000@live.com>
>
> usbvision is another driver that is scheduled for removal by the end of the year,
> so I won't apply this patch.
>
> > ---
> > drivers/staging/media/usbvision/usbvision-i2c.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c b/drivers/staging/media/usbvision/usbvision-i2c.c
> > index 6e4df3335b1b..010ad03c6ec1 100644
> > --- a/drivers/staging/media/usbvision/usbvision-i2c.c
> > +++ b/drivers/staging/media/usbvision/usbvision-i2c.c
> > @@ -32,7 +32,7 @@ MODULE_PARM_DESC(i2c_debug, "enable debug messages [i2c]");
> > #define PDEBUG(level, fmt, args...) { \
> > if (i2c_debug & (level)) \
> > printk(KERN_INFO KBUILD_MODNAME ":[%s:%d] " fmt, \
> > - __func__, __LINE__ , ## args); \
> > + __func__, __LINE__, ## args); \
>
> Actually, older (buggy) gcc compiler needed a space there, if memory serves.
Yes, that will break on old versions of gcc. crazy...
next prev parent reply other threads:[~2020-06-26 14:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 14:32 [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW) B K Karthik
2020-06-26 14:36 ` Hans Verkuil
2020-06-26 14:47 ` Greg Kroah-Hartman [this message]
2020-06-26 15:42 ` B K KARTHIK PES2201800185STUDENT ECE DeptPESU EC Campus
2020-06-27 5:07 ` Greg Kroah-Hartman
2020-06-27 8:28 ` Hans Verkuil
2020-06-27 8:49 ` Greg Kroah-Hartman
2020-06-27 8:58 ` B K Karthik
2020-06-27 9:20 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626144718.GA1218319@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bkkarthik@pesu.pes.edu \
--cc=devel@driverdev.osuosl.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox