From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C194C433DF for ; Fri, 26 Jun 2020 15:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59DD22081A for ; Fri, 26 Jun 2020 15:31:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qsgF+eG5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgFZPbY (ORCPT ); Fri, 26 Jun 2020 11:31:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725275AbgFZPbY (ORCPT ); Fri, 26 Jun 2020 11:31:24 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5B21C03E979 for ; Fri, 26 Jun 2020 08:31:23 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id s10so9874552wrw.12 for ; Fri, 26 Jun 2020 08:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Z79Xn2ytfLRDJlBOWEMRlNKpTQq7eZRoHYN4S12R0hY=; b=qsgF+eG5zi88+Xt1pcJnX7+8UFAsvZWpIVBpNbGWK+arUYAqgpvet0eg6Nz6Iamofd 61kONqQsBjhbukfj/k4BsZASz0CwKVsJ7diQQp5UR4rlnPZEjahQ3hdqLbufRzsdDQNB Y5P4pREKRp5lDnKyC+awNz9txTFXqb+TjOD/v9hXEOLQTa88fKiE+oWMb2LDrPpOoDMF xGPIrWZmSzs63RV8eFTriV27jvuBjo2XIsBmW8Gb+8wYNXf5tRgWdC3niWtp/mYBvmd8 9Rg/CU1fzkqsnkiisQsD8dKI8/Q6Aa7tqAKK213r7x+B/iBEoC61W61czbTW9nH7An+d 1+og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Z79Xn2ytfLRDJlBOWEMRlNKpTQq7eZRoHYN4S12R0hY=; b=bBVkJjuD35sHHJMPrqVFWE2NbI+PD0WUB6eO7TWXgjTKIe5ud1wE9a5NVvgTwvWGRX X54kjKqN6ANMWJP66+fNiDeyhE2xrSnbW4SEK0X/JqSbVWHuuehRW+/6lY8o1r6dbiK8 2RO4vmqWKp7c+I6w1DglYul4amwkfqijm9ZiuC+uJE+SB2m/y4FO63N1JlkEAeGsGqdH 3eJJ+EsqacIt81524nMZrqxAirIcWLBAhTrI87Us+83mqNb/KufB+o/X8I+lpfFJaljz Sj8Ih/imzekqvozvCHR6fMfNvCmCwYbrW7xolvyf13IsFVRZ4oHiIKD1kIZwCAmjk4gk wHow== X-Gm-Message-State: AOAM533nr2tv6DiKOvR598FshSNm8IobFT7CAWQQTrxmdzT3B6DSMSXB x2bfGDIgKkIPlnhRkZZwDOlQBA== X-Google-Smtp-Source: ABdhPJxWxlkMZnJ8t8xwSYOJAkftwwfg7dvAGODCCccNrSs1Wd3xLYOWg3KAZANF/AkGBiHIOO3zEw== X-Received: by 2002:adf:8168:: with SMTP id 95mr4443592wrm.104.1593185482649; Fri, 26 Jun 2020 08:31:22 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id c6sm17193641wma.15.2020.06.26.08.31.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 08:31:21 -0700 (PDT) Date: Fri, 26 Jun 2020 16:31:19 +0100 From: Lee Jones To: Mark Brown Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russ Dill , Keerthy , AnilKumar Ch , linux-omap@vger.kernel.org Subject: Re: [PATCH 6/9] regulator: tps65217-regulator: Use the returned value of tps65217_reg_read() Message-ID: <20200626153119.GC177734@dell> References: <20200626065738.93412-1-lee.jones@linaro.org> <20200626065738.93412-7-lee.jones@linaro.org> <20200626133304.GB5289@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200626133304.GB5289@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Jun 2020, Mark Brown wrote: > On Fri, Jun 26, 2020 at 07:57:35AM +0100, Lee Jones wrote: > > > Until now the aforementioned return value has been ignored. > > This is only aforementioned in the subject. > > > /* Store default strobe info */ > > ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val); > > + if (ret) > > + return ret; > > + > > We should really be logging an error there rather than just returning, > that way it's a bit more apparent to someone debugging things what went > wrong if there is actually a problem. Would you like me to fix that up subsequently? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog