Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight

Lee Jones
2020-06-24T15:43:27Z

On Wed, 24 Jun 2020, Sam Ravnborg wrote:

> Hi Lee.
>
> On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote:
> > Attempting to clean-up W=1 kernel builds, which are currently
> > overwhelmingly riddled with niggly little warnings.
> >
> > Lee Jones (8):
> > backlight: lms501kf03: Remove unused const variables
> > backlight: lcd: Add missing kerneldoc entry for 'struct device parent'
>
>
> > backlight: ili922x: Add missing kerneldoc descriptions for
> > CHECK_FREQ_REG() args
> > backlight: ili922x: Remove invalid use of kerneldoc syntax
> > backlight: ili922x: Add missing kerneldoc description for
> > ili922x_reg_dump()'s arg
> I wonder why these warnings show up as nothing pulls in this .c file.
> Anyway I would suggest to drop using kerneldoc syntax for single drivers
> like this - and the benefit here is low.
> Now they are typed, otherwise this ahd been fine in a single patch.

What do you mean by 'nothing pulls it in'?

> > backlight: backlight: Supply description for function args in existing
> > Kerneldocs
> > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0
> > backlight: qcom-wled: Remove unused configs for LED3 and LED4
>
> The other fixes looks good.
> They are all:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>

Thanks (although this should be Reviewed-by).

> > drivers/video/backlight/backlight.c | 2 ++
> > drivers/video/backlight/ili922x.c | 8 ++++++--
> > drivers/video/backlight/lcd.c | 1 +
> > drivers/video/backlight/lm3630a_bl.c | 4 ++--
> > drivers/video/backlight/lms501kf03.c | 8 --------
> > drivers/video/backlight/qcom-wled.c | 8 --------
> > 6 files changed, 11 insertions(+), 20 deletions(-)
> >

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog