From: Douglas Anderson <dianders@chromium.org>
To: gregkh@linuxfoundation.org
Cc: evgreen@chromium.org, daniel.thompson@linaro.org,
akashast@codeaurora.org, swboyd@chromium.org,
kgdb-bugreport@lists.sourceforge.net,
linux-arm-msm@vger.kernel.org, sumit.garg@linaro.org,
vivek.gautam@codeaurora.org,
Douglas Anderson <dianders@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH 0/2] serial: qcom_geni_serial: Use the FIFOs properly for console
Date: Fri, 26 Jun 2020 13:00:31 -0700 [thread overview]
Message-ID: <20200626200033.1528052-1-dianders@chromium.org> (raw)
This series of two patches gets rid of some ugly hacks that were in
the qcom_geni_serial driver around dealing with a port that was used
for console output and dealing with a port that was being used for
kgdb.
While the character reading/writing code is now slightly more complex,
it's better to be consistently configuring the serial port the same
way and doing so avoids some corner cases where the old hacks weren't
always catching properly.
This change is slightly larger than it needs to be because I was
trying not to use global variables in the read/write functions.
Unfortunately the functions were sometimes called earlycon which
didn't have any "private_data" pointer set. I've tried to do the
minimal change here to have some shared "private_data" that's always
present, but longer term it wouldn't hurt to see if we could unify
more.
Greg / Andy / Bjorn:
This series of patches is atop the current Qualcomm tree to avoid
conflicts. Assuming it looks OK, presumably the best way for it to
land would be to get an Ack from Greg and then Bjorn or Andy could
land it.
Douglas Anderson (2):
serial: qcom_geni_serial: Make kgdb work even if UART isn't console
serial: qcom_geni_serial: Always use 4 bytes per TX FIFO word
drivers/tty/serial/qcom_geni_serial.c | 129 ++++++++++++++++++--------
1 file changed, 88 insertions(+), 41 deletions(-)
--
2.27.0.212.ge8ba1cc988-goog
next reply other threads:[~2020-06-26 20:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 20:00 Douglas Anderson [this message]
2020-06-26 20:00 ` [PATCH 1/2] serial: qcom_geni_serial: Make kgdb work even if UART isn't console Douglas Anderson
2020-07-10 17:38 ` Evan Green
2020-07-10 18:19 ` Doug Anderson
2020-07-10 19:02 ` Evan Green
2020-07-10 19:24 ` Doug Anderson
2020-07-10 23:15 ` Evan Green
2020-06-26 20:00 ` [PATCH 2/2] serial: qcom_geni_serial: Always use 4 bytes per TX FIFO word Douglas Anderson
2020-07-10 17:38 ` Evan Green
2020-07-10 18:27 ` Doug Anderson
2020-07-10 19:05 ` Evan Green
2020-06-27 13:59 ` [PATCH 0/2] serial: qcom_geni_serial: Use the FIFOs properly for console Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626200033.1528052-1-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=evgreen@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox