From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDE7C433DF for ; Fri, 26 Jun 2020 21:40:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47835206A5 for ; Fri, 26 Jun 2020 21:40:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u9Zydu+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbgFZVkb (ORCPT ); Fri, 26 Jun 2020 17:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbgFZVkb (ORCPT ); Fri, 26 Jun 2020 17:40:31 -0400 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2783C03E979; Fri, 26 Jun 2020 14:40:30 -0700 (PDT) Received: by mail-ed1-x543.google.com with SMTP id e15so8010819edr.2; Fri, 26 Jun 2020 14:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=4dtaHq7RJqNsgj0DxlS9fhiPuUoM0iQPtx7ZzHAiU4s=; b=u9Zydu+IlMh9/LszZ92CggQlY9OQl1g+evFpM5Es9gv9XLcQcc+9KabLPAuenDbKtx EXSDWShwfIlbTrrA57mrRRMWbHDUrnzb1X45qD79S1Tm2MZHqDuAERzRF/Oko05LY0ed yy0vpHQkgV7P9tPEsYAHbX1VIep+NblU+/b9YtRORhq9nwD+OliGRjs9zS+sYJeg6AD3 BTSPgED2cZEaoEQ4O4wnTCpZL1fofxzDNNVHnBwoHG1irycB1yN46eUaUJ+y86fTk2sK osCLm2sFh/gulrBchGzIQkA+akXv4utKMlVQosr/uo3vX3tk/7qmGwJS3RhK389cZbgX 5zfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=4dtaHq7RJqNsgj0DxlS9fhiPuUoM0iQPtx7ZzHAiU4s=; b=j3d4KmxtbpxywlGnIsleoZKPvlKbdDFTmLa3U6/JuzFdu9zXgUkWthVBqFXUAkH8Ry LI+dg/kjHIEwcn0BupgJd7oiD8/WPlKFf1aoemC3civ7lKjQZA7anYSoIiy6cmUZF39w Q6QnwL0c7q23tWLdjyc0zrTCBnh01oYOy0BqIgZNxvesP0efmf10j+lkddItmJdC3X4f 6tPnYfJ4GQAuLRHsQl+lQwRCIkVYqe7C085SglIJsCBRhuavOgIVXftNIWeUTMaC4bQk duHxc3g1YgcTjtiJreqYZqwKjgsdYvLm+dNYd0QopBthhBj9yS0Vy25Hd6+VIHxTJ3Yw D5Fw== X-Gm-Message-State: AOAM530cNlYFixCC6F6/a6iRLEFQY8Vp9ThGf3U9tJqxt2so+6XWHaHn tkxsPMYUe028IibHcsE3/QQ= X-Google-Smtp-Source: ABdhPJy++/BzY6fHC4sgfGghocYPBjr++MH93TDtva6eLgfryARtAm541FP5Kvsf3weDh6k7PXqJhg== X-Received: by 2002:a05:6402:3113:: with SMTP id dc19mr4552096edb.20.1593207629538; Fri, 26 Jun 2020 14:40:29 -0700 (PDT) Received: from dumbo ([2a0b:f4c2::1]) by smtp.gmail.com with ESMTPSA id mf24sm918386ejb.58.2020.06.26.14.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 14:40:28 -0700 (PDT) Received: from cavok by dumbo with local (Exim 4.92) (envelope-from ) id 1jow5C-00070x-PD; Fri, 26 Jun 2020 23:40:26 +0200 Date: Fri, 26 Jun 2020 23:40:26 +0200 From: Domenico Andreoli To: Masahiro Yamada Cc: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Olof Johansson , Will Deacon , Catalin Marinas Subject: Re: [PATCH v2] kbuild: buildtar: add arm64 dtbs support Message-ID: <20200626214026.GB25753@dumbo> Mail-Followup-To: Masahiro Yamada , Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , Olof Johansson , Will Deacon , Catalin Marinas References: <5ef50e52.1c69fb81.b6cbd.bd8e@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 26, 2020 at 03:16:58PM +0900, Masahiro Yamada wrote: > On Fri, Jun 26, 2020 at 5:51 AM Domenico Andreoli > wrote: > > > > From: Domenico Andreoli > > > > Make 'make tar-pkg' install dtbs on arm64. > > > > Signed-off-by: Domenico Andreoli > > > > v2: > > - Destination path includes the kernel version, as expected > > > > --- > > scripts/package/buildtar | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > Index: b/scripts/package/buildtar > > =================================================================== > > --- a/scripts/package/buildtar > > +++ b/scripts/package/buildtar > > @@ -125,6 +125,15 @@ case "${ARCH}" in > > ;; > > esac > > > > +# > > +# Install dtbs > > +# > > +case "${ARCH}" in > > Instead of checking ${ARCH}, > can you you do > > if grep -q '^CONFIG_OF_EARLY_FLATTREE=y' include/config/auto.conf; then > > ? Done in v3. > > This is what the deb package build does: > https://github.com/masahir0y/linux/blob/v5.7/scripts/package/builddeb#L145 > > > > + arm64) > > + make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_DTBS_PATH="${tmpdir}/boot/dtbs/${KERNELRELEASE}" dtbs_install > > + ;; > > +esac > > + > > > Or, you can use INSTALL_PATH="${tmpdir}/boot" > to make it shorter. This does not work, INSTALL_DTBS_PATH gets somehow defined along the twisted path to buildtar and therefore needs to be explicitly specified for the new destination. > -- > Best Regards > Masahiro Yamada Thank you for the review. Regards, Domenico -- rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13 ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05