public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Changbin Du <changbin.du@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: [PATCH v2 06/15] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size
Date: Sat, 27 Jun 2020 21:36:45 +0800	[thread overview]
Message-ID: <20200627133654.64863-7-changbin.du@gmail.com> (raw)
In-Reply-To: <20200627133654.64863-1-changbin.du@gmail.com>

This adds an option '-m/--buffer-size' to allow us set the size of per-cpu
tracing buffer.

Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
 tools/perf/Documentation/perf-ftrace.txt |  4 ++++
 tools/perf/builtin-ftrace.c              | 22 ++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
index fd1776deebd7..a18d640e90bb 100644
--- a/tools/perf/Documentation/perf-ftrace.txt
+++ b/tools/perf/Documentation/perf-ftrace.txt
@@ -60,6 +60,10 @@ OPTIONS
 	Ranges of CPUs are specified with -: 0-2.
 	Default is to trace on all online CPUs.
 
+-m::
+--buffer-size::
+	Set the size of per-cpu tracing buffer in KB.
+
 -T::
 --trace-funcs=::
 	Only trace functions given by the argument.  Multiple functions
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 003efa756322..e45496012611 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -39,6 +39,7 @@ struct perf_ftrace {
 	struct list_head	nograph_funcs;
 	int			graph_depth;
 	unsigned		initial_delay;
+	unsigned		buffer_size_kb;
 };
 
 struct filter_entry {
@@ -321,6 +322,20 @@ static int set_tracing_depth(struct perf_ftrace *ftrace)
 	return 0;
 }
 
+static int set_tracing_buffer_size_kb(struct perf_ftrace *ftrace)
+{
+	int ret;
+
+	if (ftrace->buffer_size_kb == 0)
+		return 0;
+
+	ret = write_tracing_file_int("buffer_size_kb", ftrace->buffer_size_kb);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
 static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 {
 	char *trace_file;
@@ -385,6 +400,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 		goto out_reset;
 	}
 
+	if (set_tracing_buffer_size_kb(ftrace) < 0) {
+		pr_err("failed to set tracing per-cpu buffer size\n");
+		goto out_reset;
+	}
+
 	if (write_tracing_file("current_tracer", ftrace->tracer) < 0) {
 		pr_err("failed to set current_tracer to %s\n", ftrace->tracer);
 		goto out_reset;
@@ -555,6 +575,8 @@ int cmd_ftrace(int argc, const char **argv)
 		    "Max depth for function graph tracer"),
 	OPT_UINTEGER('d', "delay", &ftrace.initial_delay,
 		     "ms to wait before starting tracing after program start"),
+	OPT_UINTEGER('m', "buffer-size", &ftrace.buffer_size_kb,
+		     "size of per cpu buffer in kb"),
 	OPT_END()
 	};
 
-- 
2.25.1


  parent reply	other threads:[~2020-06-27 13:38 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 13:36 [PATCH v2 00/15] perf: ftrace enhancement Changbin Du
2020-06-27 13:36 ` [PATCH v2 01/15] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-07-03  5:47   ` Namhyung Kim
2020-07-07 15:00     ` Changbin Du
2020-06-27 13:36 ` [PATCH v2 02/15] perf ftrace: add option '-F/--funcs' to list available functions Changbin Du
2020-07-03  5:58   ` Namhyung Kim
2020-07-07 15:15     ` Changbin Du
2020-06-27 13:36 ` [PATCH v2 03/15] perf ftrace: add option -t/--tid to filter by thread id Changbin Du
2020-06-27 13:36 ` [PATCH v2 04/15] perf ftrace: add option -d/--delay to delay tracing Changbin Du
2020-06-27 13:36 ` [PATCH v2 05/15] perf ftrace: factor out function write_tracing_file_int() Changbin Du
2020-07-07 16:09   ` Steven Rostedt
2020-07-07 16:10     ` Steven Rostedt
2020-07-08 12:53     ` Changbin Du
2020-07-07 16:24   ` Arnaldo Carvalho de Melo
2020-06-27 13:36 ` Changbin Du [this message]
2020-07-03  6:17   ` [PATCH v2 06/15] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size Namhyung Kim
2020-06-27 13:36 ` [PATCH v2 07/15] perf ftrace: show trace column header Changbin Du
2020-07-03  6:20   ` Namhyung Kim
2020-07-03 12:35     ` Arnaldo Carvalho de Melo
2020-07-07 14:06     ` Changbin Du
2020-06-27 13:36 ` [PATCH v2 08/15] perf ftrace: add option '--inherit' to trace children processes Changbin Du
2020-06-27 13:36 ` [PATCH v2 09/15] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-07-03  6:30   ` Namhyung Kim
2020-07-07 15:19     ` Changbin Du
2020-06-27 13:36 ` [PATCH v2 10/15] perf ftrace: add support for trace option sleep-time Changbin Du
2020-07-03  6:40   ` Namhyung Kim
2020-07-07 15:35     ` Changbin Du
2020-07-07 16:09       ` Arnaldo Carvalho de Melo
2020-07-08 12:59         ` Changbin Du
2020-06-27 13:36 ` [PATCH v2 11/15] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-07-03  6:43   ` Namhyung Kim
2020-06-27 13:36 ` [PATCH v2 12/15] perf ftrace: add support for tracing option 'irq-info' Changbin Du
2020-06-27 13:36 ` [PATCH v2 13/15] perf ftrace: add option '--graph-verbose' to show more info for graph tracer Changbin Du
2020-06-27 13:36 ` [PATCH v2 14/15] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-06-27 13:36 ` [PATCH v2 15/15] perf ftrace: add change log Changbin Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200627133654.64863-7-changbin.du@gmail.com \
    --to=changbin.du@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox