From: Steven Rostedt <rostedt@goodmis.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>, Jason Gunthorpe <jgg@ziepe.ca>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Peter Zijlstra <peterz@infradead.org>,
Vinod Koul <vkoul@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
Will Deacon <will@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
bpf@vger.kernel.org
Subject: Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option
Date: Sun, 28 Jun 2020 15:00:15 -0400 [thread overview]
Message-ID: <20200628150015.363009dd@oasis.local.home> (raw)
In-Reply-To: <20200628144616.52f09152@oasis.local.home>
On Sun, 28 Jun 2020 14:46:16 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > We added a bunch of code to libbcc in the past to support instances,
> > but eventually removed it all due to memory overhead per instance.
> > If I recall it was ~8Mbyte per instance. That was couple years ago.
>
> I'd like to see where that 8 MB per instance came from. You can control
> the size of the instance buffers. If size is still an issue, I'll be
> happy to work with you to fix it.
Looks to be the duplication of the event directory tree. There's a lot
of duplicate data there. Instead of just punting and saying "instances
are too large" perhaps you could get someone to look at a way to
consolidate that data? I'm sure there's a lot of ways to help here.
Or you can just create a new event called bpf_printk() that passes in
and records a string and enable that automatically when a bpf module
has it. That could work as well.
In either case, your use of trace_printk() is an abuse of its purpose.
-- Steve
next prev parent reply other threads:[~2020-06-28 19:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 8:45 [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option Nicolas Boichat
2020-06-24 13:57 ` Jason Gunthorpe
2020-06-25 1:13 ` Nicolas Boichat
2020-06-24 16:04 ` Steven Rostedt
2020-06-24 17:25 ` Alexei Starovoitov
2020-06-25 2:00 ` Nicolas Boichat
2020-06-25 3:59 ` Alexei Starovoitov
2020-06-26 22:14 ` Steven Rostedt
2020-06-28 17:27 ` Alexei Starovoitov
2020-06-28 18:46 ` Steven Rostedt
2020-06-28 19:00 ` Steven Rostedt [this message]
2020-06-28 19:21 ` Alexei Starovoitov
2020-06-28 19:43 ` Steven Rostedt
2020-06-28 22:02 ` Alexei Starovoitov
2020-06-28 22:28 ` Steven Rostedt
2020-06-28 23:43 ` Steven Rostedt
2020-06-30 5:16 ` Alexei Starovoitov
2020-06-30 12:39 ` Steven Rostedt
2020-06-25 1:32 ` Nicolas Boichat
2020-06-24 17:37 ` kernel test robot
2020-06-24 19:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200628150015.363009dd@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=drinkcat@chromium.org \
--cc=gpiccoli@canonical.com \
--cc=groeck@chromium.org \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox