Re: [PATCH 4.19 011/131] btrfs: make caching_thread use btrfs_find_next_key

Pavel Machek
2020-06-30T21:09:27Z

[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]

On Mon 2020-06-29 11:33:02, Sasha Levin wrote:
> From: Josef Bacik <josef@toxicpanda.com>
>
> [ Upstream commit 6a9fb468f1152d6254f49fee6ac28c3cfa3367e5 ]
>
> extent-tree.c has a find_next_key that just walks up the path to find
> the next key, but it is used for both the caching stuff and the snapshot
> delete stuff. The snapshot deletion stuff is special so it can't really
> use btrfs_find_next_key, but the caching thread stuff can. We just need
> to fix btrfs_find_next_key to deal with ->skip_locking and then it works
> exactly the same as the private find_next_key helper.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> Signed-off-by: David Sterba <dsterba@suse.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

According to changelog, this is not known to fix a bug. Why is it
needed in stable?

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]