From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF96C433E0 for ; Tue, 30 Jun 2020 06:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EAC420759 for ; Tue, 30 Jun 2020 06:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593498317; bh=e4GbKwWlnby3ASGFrK0feBdyKd8uOMswnUpnE6FeJaw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=p3/DzwiVYBYqGBrYsRo+ww9niXbeT/U+5kH8hDifIQ/O5BKL+VljEJu7ldalCkX/7 kCz7J4xmWZGTEXICz4z/WPQPV1yPEs3QrghfB2yHOrvpo1aqbB20gsRKkXvgrxWutR +0qBo1e2adihHRP5UsHfQnf5iBd0L3b4pkyJVf3I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730085AbgF3GZP (ORCPT ); Tue, 30 Jun 2020 02:25:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:55244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725845AbgF3GZP (ORCPT ); Tue, 30 Jun 2020 02:25:15 -0400 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C87CD20672; Tue, 30 Jun 2020 06:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593498314; bh=e4GbKwWlnby3ASGFrK0feBdyKd8uOMswnUpnE6FeJaw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zQ91PRwFvjA+TfSxAJC+9fBYwEw9ng2aB5vMhFl5inHzc8feVeTmVluIS85oHmiQ7 flOXhcW90I2QIdJNNCa85UcqaF6EpjSRk4MozrdZqA2340Cpp8UqPMnnDGrs3YEwD6 FdcNn09u/URgDkHDlCihidsOmZH/rMoJkE8Iaf0E= Date: Tue, 30 Jun 2020 08:25:11 +0200 From: Mauro Carvalho Chehab To: Masahiro Yamada Cc: Maxim Levitsky , Linux Kbuild mailing list , Linux Kernel Mailing List Subject: Re: [PATCH v2 5/5] kconfig: qconf: navigate menus on hyperlinks Message-ID: <20200630082511.6f1f92c7@coco.lan> In-Reply-To: References: <45fa5ad583de1766de6169366df1df5837c5dc7c.1593423060.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, 30 Jun 2020 12:36:27 +0900 Masahiro Yamada escreveu: > On Mon, Jun 29, 2020 at 6:35 PM Mauro Carvalho Chehab > wrote: > > > > Instead of just changing the helper window to show a > > dependency, also navigate to it at the config and menu > > widgets. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > > I noticed a regression. > > Visit "Networking support", > and click "select: BPF" > from the window at the bottom. > > Nothing happens except the following error message > in the console: > > Clicked menu is invalid: ^BPF$ > > > If I apply only 1-4 in this series, > this works fine. Hmm... perhaps this is related to symbol visibility. If the clicked link is not visible, it won't be able to present the Kconfig option. I guess we can implement a mixed approach here: update just the configInfo data if it can't find the clicked item as a menu, like the enclosed patch. I'll send an updated version with this hybrid approach. Thanks, Mauro diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index f49fbac91995..fd721c6c4c94 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -1263,10 +1263,13 @@ void ConfigInfoView::clicked(const QUrl &url) break; } - if (!m) - qInfo() << "Clicked menu is invalid:" << data; - else + if (!m) { + /* Symbol is not visible as a menu */ + symbolInfo(); + emit showDebugChanged(true); + } else { emit menuSelected(m); + } free(result); delete data;