* [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN
@ 2020-06-06 19:16 Joe Perches
2020-06-06 20:02 ` Rob Clark
2020-06-30 9:33 ` Joerg Roedel
0 siblings, 2 replies; 3+ messages in thread
From: Joe Perches @ 2020-06-06 19:16 UTC (permalink / raw)
To: Rob Clark
Cc: Andy Gross, Bjorn Andersson, Joerg Roedel, linux-arm-msm, iommu,
linux-kernel, Andrew Morton
CONFIG_BIG_ENDIAN does not exist as a Kconfig symbol.
Signed-off-by: Joe Perches <joe@perches.com>
---
I don't have the hardware, so I can't tell if this is a
correct change, but it is a logical one.
Found by a test script that looks for IS_ENABLED(FOO)
where FOO must also exist in Kconfig files.
drivers/iommu/qcom_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
index c3e1fbd1988c..69e113471ecb 100644
--- a/drivers/iommu/qcom_iommu.c
+++ b/drivers/iommu/qcom_iommu.c
@@ -304,7 +304,7 @@ static int qcom_iommu_init_domain(struct iommu_domain *domain,
ARM_SMMU_SCTLR_M | ARM_SMMU_SCTLR_S1_ASIDPNE |
ARM_SMMU_SCTLR_CFCFG;
- if (IS_ENABLED(CONFIG_BIG_ENDIAN))
+ if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
reg |= ARM_SMMU_SCTLR_E;
iommu_writel(ctx, ARM_SMMU_CB_SCTLR, reg);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN
2020-06-06 19:16 [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN Joe Perches
@ 2020-06-06 20:02 ` Rob Clark
2020-06-30 9:33 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Rob Clark @ 2020-06-06 20:02 UTC (permalink / raw)
To: Joe Perches
Cc: Andy Gross, Bjorn Andersson, Joerg Roedel, linux-arm-msm,
list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>, Joerg Roedel <joro@8bytes.org>,,
linux-kernel, Andrew Morton, Stephen Boyd
On Sat, Jun 6, 2020 at 12:16 PM Joe Perches <joe@perches.com> wrote:
>
> CONFIG_BIG_ENDIAN does not exist as a Kconfig symbol.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> I don't have the hardware, so I can't tell if this is a
> correct change, but it is a logical one.
I'm not sure *anyone* has a working snapdragon big-endian setup these
days.. sboyd used to tinker with that ages ago.
But, SCTLR.E is the bit to set for big-endian, so this looks like the
right thing to do.
Reviewed-by: Rob Clark <robdclark@gmail.com>
> Found by a test script that looks for IS_ENABLED(FOO)
> where FOO must also exist in Kconfig files.
>
> drivers/iommu/qcom_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/qcom_iommu.c b/drivers/iommu/qcom_iommu.c
> index c3e1fbd1988c..69e113471ecb 100644
> --- a/drivers/iommu/qcom_iommu.c
> +++ b/drivers/iommu/qcom_iommu.c
> @@ -304,7 +304,7 @@ static int qcom_iommu_init_domain(struct iommu_domain *domain,
> ARM_SMMU_SCTLR_M | ARM_SMMU_SCTLR_S1_ASIDPNE |
> ARM_SMMU_SCTLR_CFCFG;
>
> - if (IS_ENABLED(CONFIG_BIG_ENDIAN))
> + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> reg |= ARM_SMMU_SCTLR_E;
>
> iommu_writel(ctx, ARM_SMMU_CB_SCTLR, reg);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN
2020-06-06 19:16 [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN Joe Perches
2020-06-06 20:02 ` Rob Clark
@ 2020-06-30 9:33 ` Joerg Roedel
1 sibling, 0 replies; 3+ messages in thread
From: Joerg Roedel @ 2020-06-30 9:33 UTC (permalink / raw)
To: Joe Perches
Cc: Rob Clark, Andy Gross, Bjorn Andersson, linux-arm-msm, iommu,
linux-kernel, Andrew Morton
On Sat, Jun 06, 2020 at 12:16:17PM -0700, Joe Perches wrote:
> CONFIG_BIG_ENDIAN does not exist as a Kconfig symbol.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> I don't have the hardware, so I can't tell if this is a
> correct change, but it is a logical one.
>
> Found by a test script that looks for IS_ENABLED(FOO)
> where FOO must also exist in Kconfig files.
>
> drivers/iommu/qcom_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-30 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-06 19:16 [Possible PATCH] iommu/qcom: Change CONFIG_BIG_ENDIAN to CONFIG_CPU_BIG_ENDIAN Joe Perches
2020-06-06 20:02 ` Rob Clark
2020-06-30 9:33 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox