Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

Jarkko Sakkinen
2020-07-10T11:02:19Z

On Thu, Jul 09, 2020 at 05:58:23PM -0500, Tyler Hicks wrote:
> On 2020-07-03 02:57:18, Jarkko Sakkinen wrote:
> > On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote:
> > > Jarkko, is this an ack from you?
> > >
> > > Is there anything I can do to help along this fix?
> > >
> > > I've spoke with two others that have poured through these specs to
> > > implement firmware event log parsers and they thought the change made
> > > sense.
> > >
> > > Tyler
> >
> > I revisited the original patch and this stroke into my eye:
> >
> > "This is true, for example, when firmware passes the event log to the
> > kernel via a reserved memory region described in device tree."
> >
> > During this discussion you gave an explanation what can trigger the bug
> > but in the commit message nothing anchors to anything.
> >
> > Please give a concrete example what can trigger the issue directly in
> > the commit message instead. It's obviously needed.
> >
> > In addition, you could also rewrite the existing inline comment to be
> > something more reasonable to the context.
>
> These are all fair points and I also see that there's a new conflict
> with the TPM next branch. I'll rebase the patch on the current next
> branch, expand on the commit message, and improve the comment in v2.
>
> Tyler

Thank you.

/Jarkko