From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DD9C433E0 for ; Wed, 1 Jul 2020 09:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7BF4206C3 for ; Wed, 1 Jul 2020 09:36:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gxzGBaO3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729643AbgGAJg1 (ORCPT ); Wed, 1 Jul 2020 05:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729591AbgGAJgU (ORCPT ); Wed, 1 Jul 2020 05:36:20 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1356C03E979 for ; Wed, 1 Jul 2020 02:36:19 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id a6so23086083wrm.4 for ; Wed, 01 Jul 2020 02:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=A3Kz0NchE1g9AL+675BMfZoX2zdrniMQZ46N4imRBGA=; b=gxzGBaO30l0mwMzc6ub1RdYIdLgG4adijwg0Ft+4UH7YMYdw1W9bYoSw9RtN047hyE Lk4yPO/4wU2vkLDjx7HIJiozhIU3zXd770VSbObOqJ5j3dWm36t1B1dbyJlQCy5oQj5m DDbJZ4AoYRD4MD19AUZ6o6YAlTZkGq0Vtk4d6eR1alOEMEvTIsdfMr3OslPq5bfEWJky 9nAW0PLQTbwC7uZRUJkm3DA8Vi/7Im+d61Idlj5T6Yo3Cjmh1tBjC51cWUdOy0VnUTHe D1Rrc8rlrEKM0TDcOomIH1jLPZ41wI4/LTlBtCuieg62LoZoHfI5OFRVz2KRnoUxTdPx ZVnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=A3Kz0NchE1g9AL+675BMfZoX2zdrniMQZ46N4imRBGA=; b=GnlGhX7glEcKqUjhVQ4byy33TD3wyILfieYO7W4TJEQF4L51NppDdZ/atQUDrRgSYD sKueTCdPJzWh+/Vt3KQZjHe3QV2oJ4uy+6KeHMQsA/vKUzzoKsm2wO75PUJHrM/qLI1J p/8h2z7IyuVyIVUM4v0zMlWAFdOhApu+6avQDA0y0g7RExtkKkE5nQsS1/3X/MljpRsg 0CKNMkYyiCJ+3b4zjtH2dtwBTORZ0NnOn0EfMGqQi+8PBnnaklrObiBAqQdpJB2a5Q30 WnV8O82mBdNZT8wz1CNxHbhC8tj/pZ/kx7mR7q13WKcdEm5IsApgq9fbIIfiXVzLlYUL bWnQ== X-Gm-Message-State: AOAM5302/8+plSFH1KX3BBckVNymzWhG1U2+v+6PdSWIEJ1dnjCdGh61 KtbH8fQKSx4IBHuHO7bRFSNMGg== X-Google-Smtp-Source: ABdhPJw2dae6dc2grKq8BKN4PdQ+VbgT3R4Y7a8vo1lMCWEC5UBhkcxXDuIWSm52Tku7j7tGGwCUGw== X-Received: by 2002:a5d:610a:: with SMTP id v10mr25752866wrt.108.1593596178621; Wed, 01 Jul 2020 02:36:18 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f14sm7347174wro.90.2020.07.01.02.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 02:36:17 -0700 (PDT) Date: Wed, 1 Jul 2020 10:36:16 +0100 From: Lee Jones To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Bartosz Golaszewski , linux-i2c@vger.kernel.org Subject: Re: [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used Message-ID: <20200701093616.GX1179328@dell> References: <20200701083118.45744-1-lee.jones@linaro.org> <20200701083118.45744-27-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701083118.45744-27-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... as is the case when !CONFIG_ACPI. Fixes the following W=1 kernel build warning: drivers/misc/eeprom/at24.c:228:36: warning: ‘at24_acpi_ids’ defined but not used [-Wunused-const-variable=] Signed-off-by: Lee Jones --- - Resending to add the I2C ML and Bartosz to the conversation - Looks like I missed them when running get_maintainer.pl - This patch, like all the others in the set, should go in via Misc - Although the patches are orthogonal, this makes life easier for Greg drivers/misc/eeprom/at24.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 9ff18d4961ceb..2591c21b2b5d8 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -225,7 +225,7 @@ static const struct of_device_id at24_of_match[] = { }; MODULE_DEVICE_TABLE(of, at24_of_match); -static const struct acpi_device_id at24_acpi_ids[] = { +static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = { { "INT3499", (kernel_ulong_t)&at24_data_INT3499 }, { "TPF0001", (kernel_ulong_t)&at24_data_24c1024 }, { /* END OF LIST */ }