Re: [PATCH v2] phy: zynqmp: Fix unused-function compiler warning

Vinod Koul
2020-07-01T15:05:57Z

On 01-07-20, 16:10, Tobias Klauser wrote:
> Mark xpsgtr_suspend and xpsgtr_resume as __maybe_unused to fix the
> following compiler warning when building with !CONFIG_PM_SLEEP:
>
> drivers/phy/xilinx/phy-zynqmp.c:830:12: warning: ‘xpsgtr_resume’ defined but not used [-Wunused-function]
> 830 | static int xpsgtr_resume(struct device *dev)
> | ^~~~~~~~~~~~~
> drivers/phy/xilinx/phy-zynqmp.c:819:12: warning: ‘xpsgtr_suspend’ defined but not used [-Wunused-function]
> 819 | static int xpsgtr_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~
>
> Also drop the existing #ifdef CONFIG_PM so the functions are always
> compile-checked regardless of CONFIG_PM and/or CONFIG_PM_SLEEP being
> set.

Applied, thanks

--
~Vinod