From: Vinod Koul <vkoul@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tobias Klauser <tklauser@distanz.ch>,
Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning
Date: Wed, 1 Jul 2020 19:25:43 +0530 [thread overview]
Message-ID: <20200701135543.GA2599@vkoul-mobl> (raw)
In-Reply-To: <20200701134443.GE27013@pendragon.ideasonboard.com>
Hi Laurent,
On 01-07-20, 16:44, Laurent Pinchart wrote:
> > How about marking it as __maybe_unused instead?
>
> I don't mind either, I'll let Tobias decide, but his patch seems fine,
> is there a drawback in his approach ? If it's just a matter of personal
> preference, I'd rather not require a v2.
__maybe_unused is the preferred way to do as Documented in
Documentation/process/coding-style.rst and makes code look neater..
Thanks
--
~Vinod
next prev parent reply other threads:[~2020-07-01 13:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 9:04 [PATCH] phy: zynqmp: Fix unused-function compiler warning Tobias Klauser
2020-07-01 13:19 ` Laurent Pinchart
2020-07-01 13:36 ` Vinod Koul
2020-07-01 13:44 ` Laurent Pinchart
2020-07-01 13:55 ` Vinod Koul [this message]
2020-07-01 14:00 ` Tobias Klauser
2020-07-01 14:01 ` Laurent Pinchart
2020-07-01 14:07 ` Tobias Klauser
2020-07-01 14:09 ` Laurent Pinchart
2020-07-01 14:10 ` [PATCH v2] " Tobias Klauser
2020-07-01 15:05 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701135543.GA2599@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=anurag.kumar.vulisha@xilinx.com \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox