From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D2FCC433DF for ; Wed, 1 Jul 2020 15:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2450B20760 for ; Wed, 1 Jul 2020 15:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593615858; bh=hjhEj1kmt32ON01AiaQ46U1TlOLLBrgSiID3pKEF4Ww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OXhbrKnedqEcIdvwdx6hduNgX15kD2vaG9njfS0OT884lPjUX5jUtCaRYqmL3ux2P Vs6ieN4GSnhSWVzPC+13B1jeB2GhHMk9ZofuB9C9B2j6LKD86QogR8iRR3qipiy+Eo bRHh0wnZ0ZZeyZzEywSnEZ1L0bT6usFtSks4I4iQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731728AbgGAPEQ (ORCPT ); Wed, 1 Jul 2020 11:04:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:47104 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731039AbgGAPEQ (ORCPT ); Wed, 1 Jul 2020 11:04:16 -0400 Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C42420702; Wed, 1 Jul 2020 15:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593615856; bh=hjhEj1kmt32ON01AiaQ46U1TlOLLBrgSiID3pKEF4Ww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0d5o1da3fLwEiMclM/eWi3jgM7r4JKqDohkZXx+8IBbCn5CoDZhw/VYem/vlOxWzR Q5z6bLbTTb1h4nKrjEff2GI5zs/zuzsqDe1Ak1P27ebiCBhnasykBTdv+hhWIiJZUa 6Om3t8BS2MQQoyi8YUufZF6UAIzhhrRBh8QRqZLA= Date: Wed, 1 Jul 2020 20:34:12 +0530 From: Vinod Koul To: Charles Keepax Cc: Takashi Iwai , Jaroslav Kysela , Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= , Srinivas Kandagatla , Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state Message-ID: <20200701150412.GC2599@vkoul-mobl> References: <20200629134737.105993-1-vkoul@kernel.org> <20200629134737.105993-4-vkoul@kernel.org> <20200701142032.GG71940@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701142032.GG71940@ediswmail.ad.cirrus.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-07-20, 14:20, Charles Keepax wrote: > On Mon, Jun 29, 2020 at 07:17:37PM +0530, Vinod Koul wrote: > > On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING > > state, so set that for partially draining streams in > > snd_compr_drain_notify() and use a flag for partially draining streams > > > > While at it, add locks for stream state change in > > snd_compr_drain_notify() as well. > > > > Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)") > > Reviewed-by: Srinivas Kandagatla > > Tested-by: Srinivas Kandagatla > > Signed-off-by: Vinod Koul > > --- > > Worth noting I haven't actually tested the gapless, but keeps all > the compressed capture stuff happy. Thanks for testing and review Charles. Btw Srini is adding support to fcplay so that we can do gapless testing without using HALs/players. Now that we have an public board (RB3) where compress works out of box, we should build more things on top :) -- ~Vinod