From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AA2C433DF for ; Wed, 1 Jul 2020 16:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E499B20760 for ; Wed, 1 Jul 2020 16:16:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mZQaUluV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732320AbgGAQQ4 (ORCPT ); Wed, 1 Jul 2020 12:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731751AbgGAQQ4 (ORCPT ); Wed, 1 Jul 2020 12:16:56 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBF7EC08C5C1 for ; Wed, 1 Jul 2020 09:16:55 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id b16so11186284pfi.13 for ; Wed, 01 Jul 2020 09:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=o1Sgg7IbU0gFvYtpKCHy7d7xGloLfRV101IO9faOPqc=; b=mZQaUluVZJrQmCmxAheRzLIcByPqK9nRZcGyBB7kaBDAUfszeNFlAhNfZDOHCH/AJz c0q6LZnsasW2Uhfx92rULySeKConzrsCsG8ViqtxqWqTMSWxPsRL27myOnBxWfscWnZz My4ntOdcAy9cyFbhXVWanxTTu3Bqm3lXNjXg537acWlPdbqgtlALGSVYpzHhSBUpQkfv 8SUWe1KwKkGvx9ylSCso0N4McxkKP/B2mPlMcjurvQuwCowLE8jWdcciWmORjM0E8W68 EX2yHQOvqxZKqkLEF4ccknJKE9OkiMeejTrEMmJ9CJinGCIP3GdrwLWA9bF2QS+YLvLh rk7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=o1Sgg7IbU0gFvYtpKCHy7d7xGloLfRV101IO9faOPqc=; b=dDRsuCH31e+8ImU8QDWCRwOgt/PlHxs28fFdsIZKUEsgrv5Uw8bA4W9Pmem7YlDxWd fBAlo0RSQ0d3PSRol9slKDPgxsp6w4sBGAFpfLlPQpbJjihZJDhTFnSq7k40bzG6fj5R d5uuwmP7vZRgisBR9F5i3owYc1gfKeJ5MgdEk8CmylAltrWJTFsrzt2DsNaOZrauvJ+Z USJsGQOEq4VG+z+k5m4J3A9pW4fxxuZZMziiSk2y9oV1iP84NI/2XbQJx6h75OqbjrFz wjAyqZ/SVIxBpW+f8rNBzRSL4C9vbt1acHqQMdMKmwjXUQwVqI4Me7b0KjIxWWasL5KB RKrQ== X-Gm-Message-State: AOAM532q3yoqUllRC5YUB9WPK0sFzsIxs5t+cBe2jB9fV1u0UCpCVzDB GBekvu/S2HjGmUhLZkTCmmA= X-Google-Smtp-Source: ABdhPJxqXrd7+6NKgupFNcaoMAekFm1PPcNCYnQgtjiGWEoV7BMnozWDtcYBFRYbo7rY/9gBsqivSw== X-Received: by 2002:aa7:8ac3:: with SMTP id b3mr26201793pfd.45.1593620215406; Wed, 01 Jul 2020 09:16:55 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n1sm5759327pjn.24.2020.07.01.09.16.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Jul 2020 09:16:54 -0700 (PDT) Date: Wed, 1 Jul 2020 09:16:53 -0700 From: Guenter Roeck To: Bjorn Helgaas Cc: Shawn Guo , Russell King , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH] imx: Provide correct number of resources when registering gpio devices Message-ID: <20200701161653.GA72983@roeck-us.net> References: <20200701032651.12420-1-linux@roeck-us.net> <20200701152442.GA3609842@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701152442.GA3609842@bjorn-Precision-5520> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 01, 2020 at 10:24:42AM -0500, Bjorn Helgaas wrote: > On Tue, Jun 30, 2020 at 08:26:51PM -0700, Guenter Roeck wrote: > > Since commit a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is > > invalid"), the kernel is a bit touchy when it encounters interrupt 0. > > As a result, there are lots of warnings such as the following when booting > > systems such as 'kzm'. > > Thanks for the fix. If there are others like this, I'd be glad to > help fix them since I made the kernel grumpier about this. Just point > me at the info. > > I looked at other callers of platform_device_register_resndata(). It > looks like imx_add_imx_dma() and vm_cmdline_set() have the same > problem. I'll fix those unless you're already doing it. The traceback below is the only one I have seen in my test system. Qemu doesn't support any of the architectures calling imx_add_imx_dma. I have not looked at or searched for any others. Guenter > > > WARNING: CPU: 0 PID: 1 at drivers/base/platform.c:224 platform_get_irq_optional+0x118/0x128 > > 0 is an invalid IRQ number > > Modules linked in: > > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc3 #1 > > Hardware name: Kyoto Microcomputer Co., Ltd. KZM-ARM11-01 > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [] (show_stack) from [] (dump_stack+0xe8/0x120) > > [] (dump_stack) from [] (__warn+0xe4/0x108) > > [] (__warn) from [] (warn_slowpath_fmt+0x74/0xbc) > > [] (warn_slowpath_fmt) from [] (platform_get_irq_optional+0x118/0x128) > > [] (platform_get_irq_optional) from [] (platform_irq_count+0x20/0x3c) > > [] (platform_irq_count) from [] (mxc_gpio_probe+0x8c/0x494) > > [] (mxc_gpio_probe) from [] (platform_drv_probe+0x48/0x98) > > [] (platform_drv_probe) from [] (really_probe+0x214/0x344) > > [] (really_probe) from [] (driver_probe_device+0x58/0xb4) > > [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60) > > [] (device_driver_attach) from [] (__driver_attach+0x84/0xc0) > > [] (__driver_attach) from [] (bus_for_each_dev+0x78/0xb8) > > [] (bus_for_each_dev) from [] (bus_add_driver+0x154/0x1e0) > > [] (bus_add_driver) from [] (driver_register+0x74/0x108) > > [] (driver_register) from [] (do_one_initcall+0x80/0x3b4) > > [] (do_one_initcall) from [] (kernel_init_freeable+0x170/0x208) > > [] (kernel_init_freeable) from [] (kernel_init+0x8/0x11c) > > [] (kernel_init) from [] (ret_from_fork+0x14/0x20) > > > > As it turns out, mxc_register_gpio() is a bit lax when setting the > > number of resources: it registers a resource with interrupt 0 when in > > reality there is no such interrupt. Fix the problem by not declaring > > the second interrupt resource if there is no second interrupt. > > > > Fixes: a85a6c86c25be ("driver core: platform: Clarify that IRQ 0 is invalid") > > Cc: Bjorn Helgaas > > Signed-off-by: Guenter Roeck > > --- > > arch/arm/mach-imx/devices/platform-gpio-mxc.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/mach-imx/devices/platform-gpio-mxc.c b/arch/arm/mach-imx/devices/platform-gpio-mxc.c > > index 78628ef12672..355de845224c 100644 > > --- a/arch/arm/mach-imx/devices/platform-gpio-mxc.c > > +++ b/arch/arm/mach-imx/devices/platform-gpio-mxc.c > > @@ -24,7 +24,8 @@ struct platform_device *__init mxc_register_gpio(char *name, int id, > > .flags = IORESOURCE_IRQ, > > }, > > }; > > + unsigned int nres; > > > > - return platform_device_register_resndata(&mxc_aips_bus, > > - name, id, res, ARRAY_SIZE(res), NULL, 0); > > + nres = irq_high ? ARRAY_SIZE(res) : ARRAY_SIZE(res) - 1; > > + return platform_device_register_resndata(&mxc_aips_bus, name, id, res, nres, NULL, 0); > > } > > -- > > 2.17.1 > >