From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68030C433DF for ; Thu, 2 Jul 2020 01:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C29F20748 for ; Thu, 2 Jul 2020 01:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593653369; bh=OA5u6xscy9t2k46JPnu2Yt95OyMmpfiU8Xnxkh0UXNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vwNHKs0RlfUZ0Z0FnmXOsVh50VLzWU+5e+bYDE2mRy3w9g5vbCl3trjHSkBOX5A79 9IoyFOW7QZRzmlJ/VkTiiAfpyyoUUWLjWIm1bDvKmT7kjFVKUvfUOxN+M9FieW+Bzi OM8SiXTfu0b+Vdb3DnjczvqkIzqyb8Sw8q7kVBOM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729435AbgGBB1S (ORCPT ); Wed, 1 Jul 2020 21:27:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:58150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729105AbgGBB0k (ORCPT ); Wed, 1 Jul 2020 21:26:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8E1D20884; Thu, 2 Jul 2020 01:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593653200; bh=OA5u6xscy9t2k46JPnu2Yt95OyMmpfiU8Xnxkh0UXNE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wUNCvvzyKj7wFlvsMs7OROdturAz5F1TzkM1todLVLxTxL2TXghjYZGsw6mw7ZSOC 32Iai7LFqsUGxJbBckglb8FVKyeNfjrYav0A6ioeD04YqP8uXp1xD7TmRnouv1ZhYq Z90zTVOSEUUxY4W8qnk2BPEM477QtvJYp0o+0JUw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhang Xiaoxu , Hulk Robot , Steve French , Sasha Levin , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: [PATCH AUTOSEL 4.19 20/27] cifs: update ctime and mtime during truncate Date: Wed, 1 Jul 2020 21:26:08 -0400 Message-Id: <20200702012615.2701532-20-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702012615.2701532-1-sashal@kernel.org> References: <20200702012615.2701532-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhang Xiaoxu [ Upstream commit 5618303d8516f8ac5ecfe53ee8e8bc9a40eaf066 ] As the man description of the truncate, if the size changed, then the st_ctime and st_mtime fields should be updated. But in cifs, we doesn't do it. It lead the xfstests generic/313 failed. So, add the ATTR_MTIME|ATTR_CTIME flags on attrs when change the file size Reported-by: Hulk Robot Signed-off-by: Zhang Xiaoxu Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/inode.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 51d410c6f6a47..4a38f16d944db 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -2219,6 +2219,15 @@ cifs_set_file_size(struct inode *inode, struct iattr *attrs, if (rc == 0) { cifsInode->server_eof = attrs->ia_size; cifs_setsize(inode, attrs->ia_size); + + /* + * The man page of truncate says if the size changed, + * then the st_ctime and st_mtime fields for the file + * are updated. + */ + attrs->ia_ctime = attrs->ia_mtime = current_time(inode); + attrs->ia_valid |= ATTR_CTIME | ATTR_MTIME; + cifs_truncate_page(inode->i_mapping, inode->i_size); } -- 2.25.1