Re: [PATCH net-next] net: dsa: microchip: split adjust_link() in phylink_mac_link_{up|down}()

Codrin.Ciubotariu
2020-07-02T13:14:53Z

On 02.07.2020 13:19, Russell King - ARM Linux admin wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Jul 02, 2020 at 12:54:39PM +0300, Codrin Ciubotariu wrote:
>> The DSA subsystem moved to phylink and adjust_link() became deprecated in
>> the process. This patch removes adjust_link from the KSZ DSA switches and
>> adds phylink_mac_link_up() and phylink_mac_link_down().
>>
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>
> For the code _transformation_ that the patch does:
>
> Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> as it is equivalent. However, for a deeper review of what is going
> on here, I've a question:
>
> $ grep live_ports *
> ksz8795.c: dev->live_ports = dev->host_mask;
> ksz8795.c: dev->live_ports |= BIT(port);
> ksz_common.h: u16 live_ports;
> ksz_common.c: dev->live_ports &= ~(1 << port);
> ksz_common.c: dev->live_ports |= (1 << port) & dev->on_ports;
> ksz_common.c: dev->live_ports &= ~(1 << port);
> ksz9477.c: dev->live_ports = dev->host_mask;
> ksz9477.c: dev->live_ports |= (1 << port);
>
> These are the only references to dev->live_ports, so the purpose of
> dev->live_ports seems unclear; it seems it is only updated but never
> read. Can it be removed, along with the locking in your new functions?

Sure, I'll make a patch to clean things up. I will resend this patch in
a series to mark the dependency.

Thanks and best regards,
Codrin

>
> Thanks.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
>