* [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
@ 2020-07-02 11:12 Paul Menzel
2020-07-02 11:35 ` Greg Kroah-Hartman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paul Menzel @ 2020-07-02 11:12 UTC (permalink / raw)
To: Masahiro Yamada, Greg Kroah-Hartman; +Cc: Paul Menzel, linux-kernel
Running `make savedefconfig` creates by default `defconfig`, which is,
currently, on git’s radar, for example, `git status` lists this file as
untracked.
So, add the file to `.gitignore`, so it’s ignored by git.
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitignore b/.gitignore
index 87b9dd8a163b..f07500889fba 100644
--- a/.gitignore
+++ b/.gitignore
@@ -143,6 +143,9 @@ x509.genkey
/allrandom.config
/allyes.config
+# Kconfig presets, default savedefconfg output
+/defconfig
+
# Kdevelop4
*.kdev4
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
2020-07-02 11:12 [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig` Paul Menzel
@ 2020-07-02 11:35 ` Greg Kroah-Hartman
2020-07-03 15:51 ` Masahiro Yamada
2020-07-05 7:14 ` Masahiro Yamada
2 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2020-07-02 11:35 UTC (permalink / raw)
To: Paul Menzel; +Cc: Masahiro Yamada, linux-kernel
On Thu, Jul 02, 2020 at 01:12:00PM +0200, Paul Menzel wrote:
> Running `make savedefconfig` creates by default `defconfig`, which is,
> currently, on git’s radar, for example, `git status` lists this file as
> untracked.
>
> So, add the file to `.gitignore`, so it’s ignored by git.
>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
2020-07-02 11:12 [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig` Paul Menzel
2020-07-02 11:35 ` Greg Kroah-Hartman
@ 2020-07-03 15:51 ` Masahiro Yamada
2020-07-05 7:14 ` Masahiro Yamada
2 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-07-03 15:51 UTC (permalink / raw)
To: Paul Menzel; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Running `make savedefconfig` creates by default `defconfig`, which is,
> currently, on git’s radar, for example, `git status` lists this file as
> untracked.
>
> So, add the file to `.gitignore`, so it’s ignored by git.
>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 87b9dd8a163b..f07500889fba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -143,6 +143,9 @@ x509.genkey
> /allrandom.config
> /allyes.config
>
> +# Kconfig presets, default savedefconfg output
I fixed up the typo, then applied to linux-kbuild. Thanks.
"savedefconfg" -> "savedefconfig"
(sorry, it was my typo.)
> +/defconfig
> +
> # Kdevelop4
> *.kdev4
>
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
2020-07-02 11:12 [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig` Paul Menzel
2020-07-02 11:35 ` Greg Kroah-Hartman
2020-07-03 15:51 ` Masahiro Yamada
@ 2020-07-05 7:14 ` Masahiro Yamada
2020-07-05 7:19 ` Paul Menzel
2 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2020-07-05 7:14 UTC (permalink / raw)
To: Paul Menzel; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Running `make savedefconfig` creates by default `defconfig`, which is,
> currently, on git’s radar, for example, `git status` lists this file as
> untracked.
>
> So, add the file to `.gitignore`, so it’s ignored by git.
>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> .gitignore | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 87b9dd8a163b..f07500889fba 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -143,6 +143,9 @@ x509.genkey
> /allrandom.config
> /allyes.config
>
> +# Kconfig presets, default savedefconfg output
I just noticed this comment is wrong
since 'defconfig' is not a preset.
I will change it to 'Kconfig savedefconfig output'.
Thanks.
> +/defconfig
> +
> # Kdevelop4
> *.kdev4
>
> --
> 2.27.0
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
2020-07-05 7:14 ` Masahiro Yamada
@ 2020-07-05 7:19 ` Paul Menzel
2020-07-05 15:34 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2020-07-05 7:19 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
Dear Masahiro,
Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>>
>> Running `make savedefconfig` creates by default `defconfig`, which is,
>> currently, on git’s radar, for example, `git status` lists this file as
>> untracked.
>>
>> So, add the file to `.gitignore`, so it’s ignored by git.
>>
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> ---
>> .gitignore | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 87b9dd8a163b..f07500889fba 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -143,6 +143,9 @@ x509.genkey
>> /allrandom.config
>> /allyes.config
>>
>> +# Kconfig presets, default savedefconfg output
>
>
> I just noticed this comment is wrong
> since 'defconfig' is not a preset.
>
> I will change it to 'Kconfig savedefconfig output'.
Thank you for finding my error and correcting it.
I couldn’t find out more about *presets*.
$ git grep -i preset scripts/kconfig/
$
Where can I look, so I won’t repeat the same mistake next time?
>> +/defconfig
>> +
>> # Kdevelop4
>> *.kdev4
>>
>> --
>> 2.27.0
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig`
2020-07-05 7:19 ` Paul Menzel
@ 2020-07-05 15:34 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2020-07-05 15:34 UTC (permalink / raw)
To: Paul Menzel; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
On Sun, Jul 5, 2020 at 4:19 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Masahiro,
>
>
> Am 05.07.20 um 09:14 schrieb Masahiro Yamada:
> > On Thu, Jul 2, 2020 at 8:12 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> >>
> >> Running `make savedefconfig` creates by default `defconfig`, which is,
> >> currently, on git’s radar, for example, `git status` lists this file as
> >> untracked.
> >>
> >> So, add the file to `.gitignore`, so it’s ignored by git.
> >>
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> >> ---
> >> .gitignore | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/.gitignore b/.gitignore
> >> index 87b9dd8a163b..f07500889fba 100644
> >> --- a/.gitignore
> >> +++ b/.gitignore
> >> @@ -143,6 +143,9 @@ x509.genkey
> >> /allrandom.config
> >> /allyes.config
> >>
> >> +# Kconfig presets, default savedefconfg output
> >
> >
> > I just noticed this comment is wrong
> > since 'defconfig' is not a preset.
> >
> > I will change it to 'Kconfig savedefconfig output'.
>
> Thank you for finding my error and correcting it.
>
> I couldn’t find out more about *presets*.
>
> $ git grep -i preset scripts/kconfig/
> $
>
> Where can I look, so I won’t repeat the same mistake next time?
You can find 'preset' in
Documentation/kbuild/kconfig.rst
but it does appear in the source files.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-05 15:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-02 11:12 [PATCH v2] .gitignore: Do not track `defconfig` from `make savedefconfig` Paul Menzel
2020-07-02 11:35 ` Greg Kroah-Hartman
2020-07-03 15:51 ` Masahiro Yamada
2020-07-05 7:14 ` Masahiro Yamada
2020-07-05 7:19 ` Paul Menzel
2020-07-05 15:34 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox