From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82883C433E0 for ; Thu, 2 Jul 2020 14:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5348220780 for ; Thu, 2 Jul 2020 14:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729532AbgGBOJM (ORCPT ); Thu, 2 Jul 2020 10:09:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728216AbgGBOJL (ORCPT ); Thu, 2 Jul 2020 10:09:11 -0400 Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 571C020780; Thu, 2 Jul 2020 14:09:09 +0000 (UTC) Date: Thu, 2 Jul 2020 15:09:07 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-mm@kvack.org, Will Deacon , Mark Rutland , Steve Capper , David Hildenbrand , Yu Zhao , Hsin-Yi Wang , Thomas Gleixner , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 (RESEND) 3/3] arm64/mm: Enable vmem_altmap support for vmemmap mappings Message-ID: <20200702140906.GG22241@gaia> References: <1592442930-9380-1-git-send-email-anshuman.khandual@arm.com> <1592442930-9380-4-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1592442930-9380-4-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 18, 2020 at 06:45:30AM +0530, Anshuman Khandual wrote: > Device memory ranges when getting hot added into ZONE_DEVICE, might require > their vmemmap mapping's backing memory to be allocated from their own range > instead of consuming system memory. This prevents large system memory usage > for potentially large device memory ranges. Device driver communicates this > request via vmem_altmap structure. Architecture needs to take this request > into account while creating and tearing down vemmmap mappings. > > This enables vmem_altmap support in vmemmap_populate() and vmemmap_free() > which includes vmemmap_populate_basepages() used for ARM64_16K_PAGES and > ARM64_64K_PAGES configs. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: Steve Capper > Cc: David Hildenbrand > Cc: Yu Zhao > Cc: Hsin-Yi Wang > Cc: Thomas Gleixner > Cc: Andrew Morton > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Tested-by: Jia He > Signed-off-by: Anshuman Khandual This looks fine to me: Reviewed-by: Catalin Marinas I presume this series would go into mainline via the mm tree as it touches several architectures.