From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B74E4C433E1 for ; Thu, 2 Jul 2020 16:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AB522084C for ; Thu, 2 Jul 2020 16:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726744AbgGBQeX (ORCPT ); Thu, 2 Jul 2020 12:34:23 -0400 Received: from muru.com ([72.249.23.125]:60416 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726415AbgGBQeW (ORCPT ); Thu, 2 Jul 2020 12:34:22 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E2B738062; Thu, 2 Jul 2020 16:35:14 +0000 (UTC) Date: Thu, 2 Jul 2020 09:34:19 -0700 From: Tony Lindgren To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ulf Hansson , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 1/1] arch: arm: mach-omap2: mmc: Move omap_mmc_notify_cover_event() prototype Message-ID: <20200702163419.GL37466@atomide.com> References: <20200701102317.235032-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200701102317.235032-1-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lee Jones [200701 03:24]: > When building the kernel with W=1 the build system complains of: > > drivers/mmc/host/omap.c:854:6: warning: no previous prototype for ‘omap_mmc_notify_cover_event’ [-Wmissing-prototypes] > 854 | void omap_mmc_notify_cover_event(struct device *dev, int num, int is_closed) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > If we move the prototype into a shared headerfile the build system > will be satisfied. Rather than create a whole new headerfile just > for this purpose, it makes sense to use the already existing > mmc-omap.h. Looks good to me and should not conflict with anything so feel free to queue along with your other patches: Acked-by: Tony Lindgren > Cc: Ulf Hansson > Cc: linux-mmc@vger.kernel.org > Cc: Tony Lindgren > Cc: linux-omap@vger.kernel.org > Signed-off-by: Lee Jones > --- > arch/arm/mach-omap2/mmc.h | 4 ---- > include/linux/platform_data/mmc-omap.h | 3 +++ > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-omap2/mmc.h b/arch/arm/mach-omap2/mmc.h > index 7f4e053c34344..b5533e93cb632 100644 > --- a/arch/arm/mach-omap2/mmc.h > +++ b/arch/arm/mach-omap2/mmc.h > @@ -16,7 +16,3 @@ static inline int omap_msdi_reset(struct omap_hwmod *oh) > return 0; > } > #endif > - > -/* called from board-specific card detection service routine */ > -extern void omap_mmc_notify_cover_event(struct device *dev, int slot, > - int is_closed); > diff --git a/include/linux/platform_data/mmc-omap.h b/include/linux/platform_data/mmc-omap.h > index 9acf0e87aa9be..f0b8947e6b07d 100644 > --- a/include/linux/platform_data/mmc-omap.h > +++ b/include/linux/platform_data/mmc-omap.h > @@ -116,3 +116,6 @@ struct omap_mmc_platform_data { > > } slots[OMAP_MMC_MAX_SLOTS]; > }; > + > +extern void omap_mmc_notify_cover_event(struct device *dev, int slot, > + int is_closed); > -- > 2.25.1 >