Re: [PATCH v5 06/10] arm64: dts: actions: Add DMA Controller for S700

Manivannan Sadhasivam
2020-07-12T17:24:42Z

On Thu, Jul 02, 2020 at 08:22:52PM +0530, Amit Singh Tomar wrote:
> This commit adds DMA controller present on Actions S700, it differs from
> S900 in terms of number of dma channels and requests.
>
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
> Changes since v4:
> * No change.
> Changes since v3:
> * Fixed typo in commit message.
> * Placed owl-s700-powergate.h in alphabetical order.
> Changes since v2:
> * added power-domain property as sps
> is enabled now and DMA needs it.
> Changes since v1:
> * No Change.
> Changes since RFC:
> * No Change.
> ---
> arch/arm64/boot/dts/actions/s700.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/actions/s700.dtsi b/arch/arm64/boot/dts/actions/s700.dtsi
> index f8eb72bb4125..2c78caebf515 100644
> --- a/arch/arm64/boot/dts/actions/s700.dtsi
> +++ b/arch/arm64/boot/dts/actions/s700.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/clock/actions,s700-cmu.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/owl-s700-powergate.h>
> #include <dt-bindings/reset/actions,s700-reset.h>
>
> / {
> @@ -244,5 +245,19 @@
> <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + dma: dma-controller@e0230000 {
> + compatible = "actions,s700-dma";
> + reg = <0x0 0xe0230000 0x0 0x1000>;
> + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + dma-channels = <10>;
> + dma-requests = <44>;
> + clocks = <&cmu CLK_DMAC>;
> + power-domains = <&sps S700_PD_DMA>;
> + };
> };
> };
> --
> 2.7.4
>