From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 615F2C433E0 for ; Fri, 3 Jul 2020 07:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FC2C206DF for ; Fri, 3 Jul 2020 07:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593762023; bh=93w9+i+IaO6NzhJCK0/eWazfc8scMFK/UwVaQVfiLvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XLgayd2VAZdc0jwnX7FIWe6DtQaOpkfE/EcvH8O/o/IrrcyKXY/1STpXFhJGZwGBT tNQn+FJSKjCzz6UWNEoBcDTJCHf0WWp7CNRh8utxJqzSzVDmNChqyVbRtPUxeeU0Xl IRKlFE05mvzJXwBBXdw8BSSEAdE+S+oCzir/VE+o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726272AbgGCHkW (ORCPT ); Fri, 3 Jul 2020 03:40:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:60476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725891AbgGCHkV (ORCPT ); Fri, 3 Jul 2020 03:40:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92A03206B6; Fri, 3 Jul 2020 07:40:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593762021; bh=93w9+i+IaO6NzhJCK0/eWazfc8scMFK/UwVaQVfiLvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YIMkNTFqhu1IwD8Nn5tAIY3P4/t8VD8TT9yz3A69VrbVljqzvH7r652mcJzxBOmVF KwDJ1OJxxJ1zH+zsIpnKVmYhMDJsPBra0tKqq3zlJdvbgD6on2GPfJGBwEpsCYyFr1 c1xiHB0Ly+4Em+v6gZ1mClkcH/jpRiABfQjItrFo= Date: Fri, 3 Jul 2020 09:40:25 +0200 From: Greg KH To: Viresh Kumar Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Vincent Guittot Subject: Re: [FOR-STABLE-3.9+] sched/rt: Show the 'sched_rr_timeslice' SCHED_RR timeslice tuning knob in milliseconds Message-ID: <20200703074025.GA2390868@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 03, 2020 at 12:54:04PM +0530, Viresh Kumar wrote: > From: Shile Zhang > > We added the 'sched_rr_timeslice_ms' SCHED_RR tuning knob in this commit: > > ce0dbbbb30ae ("sched/rt: Add a tuning knob to allow changing SCHED_RR timeslice") > > ... which name suggests to users that it's in milliseconds, while in reality > it's being set in milliseconds but the result is shown in jiffies. > > This is obviously confusing when HZ is not 1000, it makes it appear like the > value set failed, such as HZ=100: > > root# echo 100 > /proc/sys/kernel/sched_rr_timeslice_ms > root# cat /proc/sys/kernel/sched_rr_timeslice_ms > 10 > > Fix this to be milliseconds all around. > > Cc: # v3.9+ > Signed-off-by: Shile Zhang > Signed-off-by: Peter Zijlstra (Intel) > Cc: Linus Torvalds > Cc: Mike Galbraith > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Link: http://lkml.kernel.org/r/1485612049-20923-1-git-send-email-shile.zhang@nokia.com > Signed-off-by: Ingo Molnar > Signed-off-by: Viresh Kumar What is the git commit id of this patch in Linus's tree? thanks, greg k-h