From: Sasha Levin <sashal@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [FOR-STABLE-3.9+] sched/rt: Show the 'sched_rr_timeslice' SCHED_RR timeslice tuning knob in milliseconds
Date: Sun, 5 Jul 2020 09:30:41 -0400 [thread overview]
Message-ID: <20200705133041.GI2722994@sasha-vm> (raw)
In-Reply-To: <20200703074354.btmylgn5mxhbxywc@vireshk-i7>
On Fri, Jul 03, 2020 at 01:13:54PM +0530, Viresh Kumar wrote:
>On 03-07-20, 09:40, Greg KH wrote:
>> On Fri, Jul 03, 2020 at 12:54:04PM +0530, Viresh Kumar wrote:
>> > From: Shile Zhang <shile.zhang@nokia.com>
>> >
>> > We added the 'sched_rr_timeslice_ms' SCHED_RR tuning knob in this commit:
>> >
>> > ce0dbbbb30ae ("sched/rt: Add a tuning knob to allow changing SCHED_RR timeslice")
>> >
>> > ... which name suggests to users that it's in milliseconds, while in reality
>> > it's being set in milliseconds but the result is shown in jiffies.
>> >
>> > This is obviously confusing when HZ is not 1000, it makes it appear like the
>> > value set failed, such as HZ=100:
>> >
>> > root# echo 100 > /proc/sys/kernel/sched_rr_timeslice_ms
>> > root# cat /proc/sys/kernel/sched_rr_timeslice_ms
>> > 10
>> >
>> > Fix this to be milliseconds all around.
>> >
>> > Cc: <stable@vger.kernel.org> # v3.9+
>> > Signed-off-by: Shile Zhang <shile.zhang@nokia.com>
>> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> > Cc: Mike Galbraith <efault@gmx.de>
>> > Cc: Peter Zijlstra <peterz@infradead.org>
>> > Cc: Thomas Gleixner <tglx@linutronix.de>
>> > Link: http://lkml.kernel.org/r/1485612049-20923-1-git-send-email-shile.zhang@nokia.com
>> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
>> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>>
>> What is the git commit id of this patch in Linus's tree?
>
>I am really sorry for missing the only thing I was required to do :(
>
>commit 975e155ed8732cb81f55c021c441ae662dd040b5 upstream.
I've queued it for 4.9 and 4.4.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-07-05 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 7:24 [FOR-STABLE-3.9+] sched/rt: Show the 'sched_rr_timeslice' SCHED_RR timeslice tuning knob in milliseconds Viresh Kumar
2020-07-03 7:40 ` Greg KH
2020-07-03 7:43 ` Viresh Kumar
2020-07-05 13:30 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705133041.GI2722994@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox